fix: deployment failure because no tests were run by VMLens

[ThomasKrieger]

fix: for #1611 and following build error

This PR

moved to a new VMLens version which can handle no tests

How to test

mvn -DskipTests clean verify should run

[gemini-code-assist]

Summary of Changes

Hello @ThomasKrieger, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical deployment failure by upgrading the VMLens dependencies to a version that correctly handles scenarios where no tests are defined. This ensures that the build process no longer halts unexpectedly due to VMLens's behavior in such situations, leading to more robust and reliable deployments.

Highlights

• VMLens Dependency Update: The VMLens API and Maven plugin dependencies have been updated from version 1.2.14 to 1.2.15.
• Deployment Failure Fix: This update specifically addresses a deployment failure that occurred when VMLens was unable to run tests because no tests were present in the project.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the VMLens dependency and maven plugin to version 1.2.15 to resolve a build failure. The change is correct and addresses the issue described. I've added one suggestion to improve maintainability by using a Maven property for the VMLens version, which will make future updates easier and prevent version inconsistencies.

[gemini-code-assist]

To improve maintainability and avoid potential version mismatches, consider defining the VMLens version as a property in the <properties> section and using it for both this dependency and the vmlens-maven-plugin (line 354). This is a common practice in this pom.xml for other dependencies like Mockito.

For example:

1. Add <vmlens.version>1.2.15</vmlens.version> to the <properties> block at the top of the file.
2. Use ${vmlens.version} for the version here and for the plugin.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.41%. Comparing base (69a87a8) to head (80a7a65).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1634      +/-   ##
============================================
+ Coverage     91.80%   93.41%   +1.60%     
- Complexity      487      491       +4     
============================================
  Files            46       46              
  Lines          1184     1184              
  Branches        105      105              
============================================
+ Hits           1087     1106      +19     
+ Misses           66       48      -18     
+ Partials         31       30       -1     

Flag	Coverage Δ
unittests	93.41% <0.00%> (+1.60%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[chrfwow]

@ThomasKrieger why were no vmlens tests run, and don't we want the build to fail if no tests were run (as this could indicate a problem with out test setup)?

[ThomasKrieger]

@chrfwow this was during the release.yml github step deploy line 63:
mvn --batch-mode
--settings release/m2-settings.xml -DskipTests clean deploy

Which led to the build failure for the last pipeline.
I will check what is happening if you leave out -DskipTests and no tests are run

[chrfwow]

I'll approve this as it is only a library update. Please re-request a review if you do change something in the github actions

[ThomasKrieger]

@chrfwow I added vmlens/vmlens#45 to fix this in VMLens

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud