Skip to content

feat: Add wrapper information to the LaunchDarkly client-side provider. #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beeme1mr merged 4 commits into from
Aug 29, 2025
Merged

feat: Add wrapper information to the LaunchDarkly client-side provider. #1368

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96dd7ee
feat: Add wrapper information to the LaunchDarkly client-side provider.
kinyoklion Aug 11, 2025
cf35803
Fix tests for LaunchDarkly provider.
kinyoklion Aug 11, 2025
485d25a
Extract to constants.
kinyoklion Aug 11, 2025
a5342ed
Merge branch 'main' into rlamb/add-launchdarkly-wrapper-information
beeme1mr Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libs/providers/launchdarkly-client/src/lib/launchdarkly-client-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,12 @@ export class LaunchDarklyClientProvider implements Provider {
this.logger = basicLogger({ level: 'info' });
}
this.initializationTimeout = initializationTimeout;
this.ldOptions = { ...ldOptions, logger: this.logger };
this.ldOptions = {
...ldOptions,
logger: this.logger,
wrapperName: 'open-feature-community-js-client',
wrapperVersion: '0.3.2', // {{ x-release-please-version }}
};
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

A couple of suggestions to improve maintainability here:

  1. Avoid magic strings: The wrapperName could be defined as a constant at the top of the file for better readability and easier maintenance.
  2. Single source of truth for version: Instead of hardcoding wrapperVersion and relying on release-please to update it, you could import it from package.json. This would make package.json the single source of truth and you could remove the extra-files config from release-please-config.json.

Here's how you could implement these changes:

At the top of the file, add:

import { version } from '../../package.json';

const WRAPPER_NAME = 'open-feature-community-js-client';

Then update this block to:

Suggested change
this.ldOptions = {
...ldOptions,
logger: this.logger,
wrapperName: 'open-feature-community-js-client',
wrapperVersion: '0.3.2', // {{ x-release-please-version }}
};
this.ldOptions = {
...ldOptions,
logger: this.logger,
wrapperName: WRAPPER_NAME,
wrapperVersion: version,
};

}

private get client(): LDClient {
Expand Down
5 changes: 4 additions & 1 deletion release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@
"prerelease": false,
"bump-minor-pre-major": true,
"bump-patch-for-minor-pre-major": true,
"versioning": "default"
"versioning": "default",
"extra-files": [
"src/lib/launchdarkly-client-provider.ts"
]
},
"libs/providers/go-feature-flag-web": {
"release-type": "node",
Expand Down
Loading