Skip to content

Conversation

jonathannorris
Copy link
Member

@jonathannorris jonathannorris commented Oct 16, 2025

Enabling "release-as": "patch" in the release-please-config.json config per-package will trigger patch releases for each package, allowing us to test NPM OIDC connections with a patch release.

…er patch release for all packages

Signed-off-by: Jonathan Norris <[email protected]>
@jonathannorris jonathannorris requested review from a team as code owners October 16, 2025 16:03
Copy link
Contributor

Summary of Changes

Hello @jonathannorris, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a configuration change to the release-please-config.json file, setting the default release type to 'patch'. This modification ensures that all subsequent releases managed by the release-please automation will be patch versions, aiming to streamline the release workflow for minor updates across all packages within the repository.

Highlights

  • Release Configuration: The release-please-config.json file has been updated to include the "release-as": "patch" setting.
  • Default Release Type: This change configures the release-please bot to trigger patch releases by default for all packages, standardizing the release process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds release-as: "patch" to the release-please-config.json. This will force all future releases to be patch-level releases, overriding the versioning logic based on Conventional Commits. This is generally used for one-off releases and can be problematic if left in the main configuration, as it will prevent automatic minor and major version bumps. My review includes a comment on this change with a recommendation to handle one-off releases differently to preserve the semantic versioning automation.

@@ -1,5 +1,6 @@
{
"bootstrap-sha": "64eadd1b615997440ab4a246b941a24d13abd220",
"release-as": "patch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding release-as: "patch" to the root of the configuration will force all future releases for all packages to be patch releases. This overrides the automatic version bumping based on Conventional Commit messages (e.g., feat: for minor, fix: for patch, BREAKING CHANGE for major).

If this is intended for a one-time patch release, this change should not be merged into the main branch. Instead, the release-as parameter should be provided directly to the release-please action or command for that specific run, which avoids permanently altering the release behavior.

Leaving this in the configuration will prevent automatic minor and major version bumps. Is this the intended long-term behavior?

@jonathannorris jonathannorris changed the title chore: enable release-as=patch for the release-please-config to trigger patch release for all packages chore: enable release-as=patch for release-please to trigger patch release for all packages Oct 16, 2025
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this is correct. I think you need to set release-as per package and use the version you want released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants