Skip to content

fix: multi-provider hook context management #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beeme1mr merged 2 commits into from
Nov 19, 2025
Merged

fix: multi-provider hook context management #1282

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41f2621
fix: multi-provider hook context management
mdkitzman Nov 13, 2025
c5ecbcf
fix: open-feature-client context management
mdkitzman Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions packages/server/src/provider/multi-provider/multi-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,8 @@ export class MultiProvider implements Provider {

public readonly events = new OpenFeatureEventEmitter();

private hookContexts: WeakMap<EvaluationContext, HookContext> = new WeakMap<EvaluationContext, HookContext>();
private hookHints: WeakMap<EvaluationContext, HookHints> = new WeakMap<EvaluationContext, HookHints>();

private hookContents: Array<[HookContext, HookHints]> = [];

metadata: ProviderMetadata;

providerEntries: RegisteredProvider[] = [];
Expand Down Expand Up @@ -140,9 +139,8 @@ export class MultiProvider implements Provider {
defaultValue: T,
context: EvaluationContext,
): Promise<ResolutionDetails<T>> {
const hookContext = this.hookContexts.get(context);
const hookHints = this.hookHints.get(context);

const [hookContext, hookHints] = this.hookContents.shift() ?? [];

if (!hookContext || !hookHints) {
throw new GeneralError('Hook context not available for evaluation');
}
Expand Down Expand Up @@ -299,8 +297,7 @@ export class MultiProvider implements Provider {
return [
{
before: async (hookContext: BeforeHookContext, hints: HookHints): Promise<EvaluationContext> => {
this.hookContexts.set(hookContext.context, hookContext);
this.hookHints.set(hookContext.context, hints ?? {});
this.hookContents.push([hookContext, hints ?? {}]);
return hookContext.context;
},
},
Expand Down