-
Notifications
You must be signed in to change notification settings - Fork 49
chore: release main #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: release main #1288
Conversation
Summary of ChangesHello @openfeaturebot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated release generated by Release Please, which updates the versions of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by Release Please, prepares new releases for @openfeature/nestjs-sdk (v0.2.6) and @openfeature/react-sdk (v1.0.3). The changes include version bumps in package.json files and updates to the changelogs. However, I've identified a critical issue where devDependencies in both updated packages are being pinned to versions of other workspace packages that are not being released in this PR and do not seem to exist. This will likely cause dependency installation to fail and should be addressed before merging.
| "@nestjs/testing": "^11.0.20", | ||
| "@openfeature/core": "*", | ||
| "@openfeature/server-sdk": "1.18.0", | ||
| "@openfeature/server-sdk": "1.20.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The devDependency on @openfeature/server-sdk is being updated to version 1.20.1. However, based on the files in this pull request and the repository context, the latest version of @openfeature/server-sdk appears to be 1.20.0, and it is not being updated as part of this release. This will likely cause dependency resolution to fail. Please ensure that the dependency versions are correct and point to existing or soon-to-be-published versions within this same release.
packages/react/package.json
Outdated
| "devDependencies": { | ||
| "@openfeature/core": "*", | ||
| "@openfeature/web-sdk": "*" | ||
| "@openfeature/web-sdk": "1.7.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The devDependency on @openfeature/web-sdk is being updated from * to 1.7.2. While pinning dependencies is a good practice, the version 1.7.2 of @openfeature/web-sdk does not seem to exist within this pull request's context. The current version appears to be 1.7.1, and it's not being updated in this release. This will likely break dependency installation. Please verify the target version.
a73bcb5 to
82637a2
Compare
Signed-off-by: OpenFeature Bot <[email protected]>
82637a2 to
26d8ded
Compare
🤖 I have created a release beep boop
@openfeature/nestjs-sdk: 0.2.6
Dependencies
@openfeature/react-sdk: 1.0.3
Dependencies
This PR was generated with Release Please. See documentation.