-
Notifications
You must be signed in to change notification settings - Fork 54
chore(main): release web-sdk 1.7.3 #1338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(main): release web-sdk 1.7.3 #1338
Conversation
Signed-off-by: OpenFeature Bot <[email protected]>
Summary of ChangesHello @openfeaturebot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents an automated release for the OpenFeature Web-SDK, advancing its version to 1.7.3. The update primarily incorporates a refactoring change that relocates shared Multi-Provider code into the core package, alongside a minor update to a development dependency. This ensures the Web-SDK remains current and benefits from shared core functionalities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is for the release of web-sdk version 1.7.3. The changes are mainly version bumps and documentation updates, which appear to be standard for a release. However, I've noticed a potential issue with the peerDependencies configuration in packages/web/package.json. While a devDependency is updated, the corresponding peerDependency is not, which could cause issues for users of this package. Please see my specific comment for details.
| "devDependencies": { | ||
| "@openfeature/core": "^1.9.0" | ||
| "@openfeature/core": "^1.9.2" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The devDependencies for @openfeature/core is being updated to ^1.9.2, but the peerDependencies version for it on line 53 remains ^1.9.0. The changelog indicates that multi-provider code was moved to the core package, which likely means this SDK now requires a newer version of @openfeature/core.
To prevent potential runtime errors for consumers of this package, the peerDependencies should be updated to reflect the new minimum required version. If features from @openfeature/[email protected] are now necessary, the peerDependencies should be bumped to ^1.9.2.
toddbaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to #1324, we will have to update the minimum core version to 1.9.2 so that references from this SDK to core do not break.
I will do this manually on release.
🤖 I have created a release beep boop
1.7.3 (2026-01-29)
🔄 Refactoring
Dependencies
This PR was generated with Release Please. See documentation.