Skip to content

Conversation

@PenguinDan
Copy link
Contributor

@PenguinDan PenguinDan commented Nov 22, 2025

This PR

Adds support for the iOS target to the Kotlin SDK.

  • Adds iosArm64, iosX64, and iosSimulatorArm64 targets to the build configuration.
  • Updates the README.md to reflect iOS support.

A major use case for a Kotlin SDK is allowing the implementation to be utilized on Kotlin Multiplatform projects, so updating things here to support that use case

Related Issues

This change enables the SDK to be used in Kotlin Multiplatform Mobile (KMM) projects targeting iOS devices and simulators (both Apple Silicon and Intel).

Follow-up Tasks

  • specific iOS integration tests

@gemini-code-assist
Copy link

Summary of Changes

Hello @PenguinDan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Kotlin SDK's compatibility by introducing support for iOS targets. This enhancement allows the SDK to be seamlessly integrated into Kotlin Multiplatform Mobile (KMM) projects, enabling developers to target iOS devices and simulators across both Apple Silicon and Intel architectures. The change primarily involves updating the build configuration and documentation to reflect this new capability.

Highlights

  • iOS Target Support: Added support for iOS targets (iosArm64, iosX64, and iosSimulatorArm64) to the Kotlin SDK build configuration.
  • Documentation Update: Updated the README.md file to reflect the newly added iOS support in the list of Kotlin Multiplatform Targets.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Signed-off-by: penguindan <[email protected]>
@PenguinDan PenguinDan changed the title feaAdd iOS target feat: Add iOS target Nov 22, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for iOS targets to the Kotlin SDK, which is a great addition for enabling its use in Kotlin Multiplatform Mobile projects. The changes in README.md correctly reflect this new capability. My main feedback is on the build.gradle.kts file, where I've suggested an improvement to better configure the iOS framework output, making it easier for developers to integrate into their Xcode projects. This involves grouping the iOS targets and setting a base name for the framework, which is a common practice for KMM libraries.

@PenguinDan PenguinDan marked this pull request as draft November 22, 2025 23:12
Signed-off-by: penguindan <[email protected]>
@PenguinDan PenguinDan marked this pull request as ready for review November 22, 2025 23:24
@bencehornak
Copy link
Contributor

Thanks for this, @PenguinDan ! Since I have no Mac, I can't validate if the compilation works. Could you implement a CI/CD pipeline on a Mac worker to run tests for the new tatgets and to publish their artifacts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants