-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add iOS target #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add iOS target #196
Conversation
Summary of ChangesHello @PenguinDan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Kotlin SDK's compatibility by introducing support for iOS targets. This enhancement allows the SDK to be seamlessly integrated into Kotlin Multiplatform Mobile (KMM) projects, enabling developers to target iOS devices and simulators across both Apple Silicon and Intel architectures. The change primarily involves updating the build configuration and documentation to reflect this new capability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: penguindan <[email protected]>
72c749e to
6c032fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for iOS targets to the Kotlin SDK, which is a great addition for enabling its use in Kotlin Multiplatform Mobile projects. The changes in README.md correctly reflect this new capability. My main feedback is on the build.gradle.kts file, where I've suggested an improvement to better configure the iOS framework output, making it easier for developers to integrate into their Xcode projects. This involves grouping the iOS targets and setting a base name for the framework, which is a common practice for KMM libraries.
Signed-off-by: penguindan <[email protected]>
|
Thanks for this, @PenguinDan ! Since I have no Mac, I can't validate if the compilation works. Could you implement a CI/CD pipeline on a Mac worker to run tests for the new tatgets and to publish their artifacts? |
This PR
Adds support for the iOS target to the Kotlin SDK.
iosArm64,iosX64, andiosSimulatorArm64targets to the build configuration.README.mdto reflect iOS support.A major use case for a Kotlin SDK is allowing the implementation to be utilized on Kotlin Multiplatform projects, so updating things here to support that use case
Related Issues
This change enables the SDK to be used in Kotlin Multiplatform Mobile (KMM) projects targeting iOS devices and simulators (both Apple Silicon and Intel).
Follow-up Tasks