feat: allow setting mutating webhook failurepolicy and objectSelector via helm #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes open-feature#654 Signed-off-by: Marco Orovecchia <[email protected]>
Oro
force-pushed
the
feat/mutatingwebhookconfig
branch
from
651fd1c to
92a5d3d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
==========================================
- Coverage 86.51% 86.25% -0.26%
==========================================
Files 19 19
Lines 1587 1681 +94
==========================================
+ Hits 1373 1450 +77
- Misses 173 184 +11
- Partials 41 47 +6 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
thisthat
approved these changes
Oct 31, 2024
Member
|
Thanks @Oro for the PR 🙌 |
Signed-off-by: Marco Orovecchia <[email protected]>
Oro
force-pushed
the
feat/mutatingwebhookconfig
branch
from
e635000 to
0d59028
Compare
lukas-reining
approved these changes
Jan 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This makes it possible to configure new pods to wait until the webhook is available. Otherwise pods will start and not get mutated, i.e. will be missing the flagd sidecar.
The objectSelector is needed so that the webhook itself can still start up as otherwise it would fail while waiting on itself.
Related Issues
Fixes #654