feat(flagd-rpc): add caching #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aepfli
force-pushed
the
feat/caching
branch
2 times, most recently
from
c4e7685 to
fcfc5ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 93.92% 94.04% +0.11%
==========================================
Files 14 14
Lines 675 705 +30
==========================================
+ Hits 634 663 +29
- Misses 41 42 +1 ☔ View full report in Codecov by Sentry. |
aepfli
force-pushed
the
feat/caching
branch
8 times, most recently
from
60974f6 to
bd25097
Compare
aepfli
commented
Nov 28, 2024
aepfli
force-pushed
the
feat/caching
branch
6 times, most recently
from
79f69bc to
50e9adb
Compare
aepfli
commented
Nov 29, 2024
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
warber
reviewed
Dec 4, 2024
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py
Outdated
Show resolved
Hide resolved
warber
reviewed
Dec 4, 2024
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Dec 4, 2024
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Schrottner <[email protected]>
beeme1mr
approved these changes
Dec 5, 2024
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
Nice job! I'm just wondering about the caching dependency but it doesn't need to block this PR.
toddbaert
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding caching to the RPC resolver
closes: #55