Skip to content

Conversation

@aepfli
Copy link
Member

@aepfli aepfli commented Nov 24, 2024

with #41 we removed the main build, and now our coverage information is not updated. Furthermore, we are not sure, if our main branch is actually building properly. This will add back execution of the build for changes to the main branch.

@beeme1mr I might miss some implications, why #41 was done, and maybe we need to do more, but i thought this pr is a good point to start discussions

@aepfli aepfli requested a review from a team as a code owner November 24, 2024 12:38
@codecov
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (d8e10c7) to head (2843a17).
Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   90.55%   95.03%   +4.47%     
==========================================
  Files           8       13       +5     
  Lines         180      483     +303     
==========================================
+ Hits          163      459     +296     
- Misses         17       24       +7     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try. If some problems pop, we can try to fix them or revert the change again.

@gruebel gruebel merged commit 5adc68a into open-feature:main Nov 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants