-
Notifications
You must be signed in to change notification settings - Fork 23
feat: Add basic env var provider #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: christian.lutnik <[email protected]>
providers/openfeature-provider-env-var/src/openfeature/contrib/provider/envvar/provider.py
Outdated
Show resolved
Hide resolved
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 94.00% 94.21% +0.21%
==========================================
Files 18 20 +2
Lines 984 1020 +36
==========================================
+ Hits 925 961 +36
Misses 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
providers/openfeature-provider-env-var/src/openfeature/contrib/provider/envvar/provider.py
Outdated
Show resolved
Hide resolved
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
providers/openfeature-provider-env-var/src/openfeature/contrib/provider/envvar/provider.py
Show resolved
Hide resolved
toddbaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm preemptively approving, but please consider this.
gruebel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, just found some minor stuff.
@beeme1mr can you setup the release on pypi side?
providers/openfeature-provider-env-var/src/openfeature/contrib/provider/envvar/provider.py
Outdated
Show resolved
Hide resolved
providers/openfeature-provider-env-var/src/openfeature/contrib/provider/envvar/provider.py
Outdated
Show resolved
Hide resolved
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
gruebel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I think everything looks good for an initial version 🍻
alexandraoberaigner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too! 🎉
This PR
Adds a very basic implementation of an env var provider
Please make sure that the repo setup is correct.
Follow-up Tasks
If we want more advanced behaviour as in the java env var provider (env var name transformation, alternative env var access logic, ...) or more tests, this can be done in a follow up PR