Skip to content

Conversation

@chrfwow
Copy link
Contributor

@chrfwow chrfwow commented Jul 4, 2025

This PR

Adds a very basic implementation of an env var provider

Please make sure that the repo setup is correct.

Follow-up Tasks

If we want more advanced behaviour as in the java env var provider (env var name transformation, alternative env var access logic, ...) or more tests, this can be done in a follow up PR

Signed-off-by: christian.lutnik <[email protected]>
@chrfwow chrfwow requested review from a team as code owners July 4, 2025 09:09
@chrfwow chrfwow changed the title Add basic env var provider feat: Add basic env var provider Jul 4, 2025
chrfwow added 3 commits July 4, 2025 11:16
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (144c725) to head (ce3fee1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
+ Coverage   94.00%   94.21%   +0.21%     
==========================================
  Files          18       20       +2     
  Lines         984     1020      +36     
==========================================
+ Hits          925      961      +36     
  Misses         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chrfwow added 7 commits July 4, 2025 11:40
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
chrfwow added 2 commits July 7, 2025 12:50
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm preemptively approving, but please consider this.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, just found some minor stuff.

@beeme1mr can you setup the release on pypi side?

chrfwow added 2 commits July 9, 2025 08:40
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I think everything looks good for an initial version 🍻

Copy link

@alexandraoberaigner alexandraoberaigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! 🎉

@aepfli aepfli merged commit 72e6bd3 into open-feature:main Jul 16, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants