fix(flagd): fix protobuf version for file generation to lowest 5.x version #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 20 20
Lines 1020 1020
=======================================
Hits 961 961
Misses 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aepfli
force-pushed
the
feat/pin_protobuf_version_to_lower_numbers
branch
4 times, most recently
from
836623d to
8757d7f
Compare
…nflict with other version Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/pin_protobuf_version_to_lower_numbers
branch
from
8757d7f to
fa7c7b6
Compare
aepfli
changed the title
gruebel
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our release artifact is built with Protobuf version 6. This can cause trouble if another version of Protobuf is used in a project. Based on https://protobuf.dev/support/cross-version-runtime-guarantee/#python, we should be able to support backward compatibility on a higher level by binding it to this range.
I removed the dependency's version bounds, and I am building the protobuf files with the latest patch version of 4.x.x.
FYI: @gruebel