Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Sep 21, 2025

This PR

  • just a few more weeks till GA
  • also updated all dependencies

Follow-up Tasks

Signed-off-by: gruebel <[email protected]>
@gruebel gruebel requested review from a team as code owners September 21, 2025 14:13
@gemini-code-assist
Copy link

Summary of Changes

Hello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the flagd_container.py test utility to adapt to changes in the testcontainers library's approach to managing container readiness. The primary goal is to ensure continued compatibility and support for Python 3.14 by modernizing the waiting mechanisms used during end-to-end testing, leading to a more robust and maintainable test setup.

Highlights

  • Updated Test Container Waiting Strategy: The pull request refactors how container readiness is handled in end-to-end tests by replacing the deprecated testcontainers.core.waiting_utils with the more modern testcontainers.core.wait_strategies module.
  • Streamlined Container Startup: A LogMessageWaitStrategy is now directly configured during the FlagdContainer initialization to wait for the 'listening' log message, simplifying the _checker method and making the startup process more explicit.
  • Python 3.14 Compatibility: These changes are part of a broader effort to ensure the project's compatibility and full support for the upcoming Python 3.14 release.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.41%. Comparing base (9590554) to head (5a90aae).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          21       21           
  Lines        1057     1057           
=======================================
  Hits          998      998           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the testcontainers usage in the e2e tests to use the newer LogMessageWaitStrategy API. While this is a good modernization, the changes to the _checker method have introduced a potential for test flakiness by removing a retry mechanism and relying on a fixed time.sleep(). I've provided a suggestion to make the health check more robust.

Also, the PR title "chore: support Python 3.14" doesn't seem to align with the changes, which are focused on refactoring test container waiting logic. It might be helpful to update the title to better reflect the content of the PR.

@gruebel gruebel merged commit 6ad6c0c into main Sep 25, 2025
38 checks passed
@gruebel gruebel deleted the support-py314 branch September 25, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants