-
Notifications
You must be signed in to change notification settings - Fork 23
chore: support Python 3.14 #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: gruebel <[email protected]>
Summary of ChangesHello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 21 21
Lines 1057 1057
=======================================
Hits 998 998
Misses 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the testcontainers usage in the e2e tests to use the newer LogMessageWaitStrategy API. While this is a good modernization, the changes to the _checker method have introduced a potential for test flakiness by removing a retry mechanism and relying on a fixed time.sleep(). I've provided a suggestion to make the health check more robust.
Also, the PR title "chore: support Python 3.14" doesn't seem to align with the changes, which are focused on refactoring test container waiting logic. It might be helpful to update the title to better reflect the content of the PR.
Signed-off-by: gruebel <[email protected]>
This PR
Follow-up Tasks
flagdexclusion. locally it worked, but compilinggrpciotakes really long.