Skip to content

Conversation

@federicobond
Copy link
Member

This PR

Replaces typing_extensions import with stdlib typing package. Protocol was introduced to the typing package in Python 3.8 which is our support floor.

Related Issues

Fixes #97

@federicobond federicobond requested a review from a team as a code owner October 21, 2024 11:57
@codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.44%. Comparing base (d8e10c7) to head (09688ab).
Report is 40 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   90.55%   92.44%   +1.88%     
==========================================
  Files           8       12       +4     
  Lines         180      463     +283     
==========================================
+ Hits          163      428     +265     
- Misses         17       35      +18     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@federicobond federicobond force-pushed the remove-typing-extensions branch from a49eb53 to 09688ab Compare October 21, 2024 11:58
@federicobond federicobond merged commit adb8a69 into open-feature:main Oct 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing typing-extensions dependency

2 participants