Skip to content

Conversation

@therb1
Copy link
Contributor

@therb1 therb1 commented Feb 5, 2025

@beeme1mr You merge it too fast =)
here is 1 more fix docs

Because of the missing slash before the parameters, the site does not perceive the request correctly. The site adds the slash it needs to the request, but ignores the parameters passed. And when clicking on the link from the readme file, the user sees a blank page. This is not a problem_PROBLEM, but if it can be fixed, why not fix it.

The problem is reproduced on Chrome and Edge browsers

Signed-off-by: Maxim <[email protected]>
fix example hooks url

Signed-off-by: Maxim <[email protected]>
fix evaluation-context docs link

Signed-off-by: Maxim <[email protected]>
@therb1 therb1 closed this Feb 5, 2025
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (fe0fea1) to head (8fa408c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files          31       31           
  Lines        1393     1393           
=======================================
  Hits         1359     1359           
  Misses         34       34           
Flag Coverage Δ
unittests 97.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant