Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Feb 7, 2025

This PR

  • I think it is time to say goodbye to Python 3.8 support, mypy dropped 3.8 support in its latest version and the flagd test suite will benefit from it

@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (d4f53b4) to head (e4aa328).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #441   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          32       32           
  Lines        1621     1621           
=======================================
  Hits         1584     1584           
  Misses         37       37           
Flag Coverage Δ
unittests 97.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruebel
Copy link
Member Author

gruebel commented Feb 7, 2025

@beeme1mr should we release it as 0.8 version or is 0.7.6 ok too?

@beeme1mr
Copy link
Member

beeme1mr commented Feb 7, 2025

I'm fine with that and recommending keeping it a breaking change so we can it's very obvious in the release notes.

I'm just wondering if we should release the async changes before merging this.

@beeme1mr
Copy link
Member

beeme1mr commented Feb 7, 2025

Python 3.8 EOL was 2024-10-07.

https://devguide.python.org/versions/

@gruebel
Copy link
Member Author

gruebel commented Feb 7, 2025

I'm just wondering if we should release the async changes before merging this.

@beeme1mr yeah I thought about the same thing. I'm somehow more inclined to put the async change with this together into the first 0.8.0 version. It is technically not a breaking change, but still quite a big new feature.

@beeme1mr
Copy link
Member

beeme1mr commented Feb 7, 2025

Sure, either way works for me. We should give folks a few days to let us know if dropping 3.8 is fine. Let's aim for merging this early next week unless we run into any blockers.

Copy link
Contributor

@leohoare leohoare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out with the old 😂

@gruebel gruebel merged commit bcd1a38 into main Feb 11, 2025
12 of 14 checks passed
@gruebel gruebel deleted the drop-py38 branch February 11, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants