-
Notifications
You must be signed in to change notification settings - Fork 12
build: reduce dependencies #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sftse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to streamline the project's dependencies and modernize its codebase. It achieves this by replacing the external Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively reduces dependencies by scoping down Tokio features and modernizes the codebase by replacing lazy_static with the standard library's OnceLock. The changes are well-executed and include several nice idiomatic improvements. I've added one suggestion to further improve maintainability by reducing a small piece of duplicated code.
54888fd to
8b0e117
Compare
Signed-off-by: c <c@farsight.net>
Signed-off-by: c <c@farsight.net>
Signed-off-by: c <c@farsight.net>
Signed-off-by: c <c@farsight.net>
| client.get_bool_value("key", None, None).await.unwrap(), | ||
| true | ||
| ); | ||
| assert!(client.get_bool_value("key", None, None).await.unwrap()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this is equivalent with the old one, but I personally prefer assert_eq! because it makes it explicit that we are expecting a boolean value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite unconventional, and the use of assert! is prevalent in src/evaluation/value.rs.
Sure about this?
Unnecessary features of tokio were removed.
Removes
lazy_staticsince the same functionality is now available on stable.