Skip to content

Conversation

@sftse
Copy link

@sftse sftse commented Nov 10, 2025

Unnecessary features of tokio were removed.

Removes lazy_static since the same functionality is now available on stable.

@gemini-code-assist
Copy link

Summary of Changes

Hello @sftse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to streamline the project's dependencies and modernize its codebase. It achieves this by replacing the external lazy_static crate with the standard library's OnceLock for singleton initialization and by optimizing the tokio feature set to include only what is essential. These changes contribute to a leaner, more efficient, and more maintainable application by reducing external dependencies and simplifying existing code patterns.

Highlights

  • Dependency Reduction: The lazy_static crate has been removed, leveraging std::sync::OnceLock which provides equivalent functionality and is now available in the standard library.
  • Tokio Feature Optimization: The tokio dependency has been refined to activate only necessary features (sync for the main dependency and macros, rt-multi-thread for dev-dependencies), reducing the overall build footprint and improving efficiency.
  • Code Modernization and Simplification: Several minor code simplifications have been applied across various files, including using assert! for boolean checks, removing unnecessary .clone() or .to_owned() calls, and simplifying format_args! and map closures, enhancing readability and maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively reduces dependencies by scoping down Tokio features and modernizes the codebase by replacing lazy_static with the standard library's OnceLock. The changes are well-executed and include several nice idiomatic improvements. I've added one suggestion to further improve maintainability by reducing a small piece of duplicated code.

@sftse sftse force-pushed the c-dev branch 3 times, most recently from 54888fd to 8b0e117 Compare November 10, 2025 08:46
Signed-off-by: c <c@farsight.net>
@sftse sftse changed the title Reduce dependencies build: reduce dependencies Nov 10, 2025
Signed-off-by: c <c@farsight.net>
Signed-off-by: c <c@farsight.net>
client.get_bool_value("key", None, None).await.unwrap(),
true
);
assert!(client.get_bool_value("key", None, None).await.unwrap());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is equivalent with the old one, but I personally prefer assert_eq! because it makes it explicit that we are expecting a boolean value.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite unconventional, and the use of assert! is prevalent in src/evaluation/value.rs.
Sure about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants