-
Notifications
You must be signed in to change notification settings - Fork 12
chore: Bump min rust version #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Fabrizio Demaria <[email protected]>
Summary of ChangesHello @fabriziodemaria, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a recent build failure by bumping the minimum required Rust version for the project. This change ensures compatibility with updated dependencies, specifically Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
8ce89a2 to
b7b7312
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly bumps the minimum supported Rust version to 1.77.0 in Cargo.toml to resolve a build issue with a dependency. The corresponding changes in README.md to update the version badge and requirements section are also included. I've suggested a small wording improvement in the README.md to more accurately reflect that the new Rust version is a strict requirement.
|
we need to change the Github settings and mark msrv action as required for merging PR to prevent this issue in future. @beeme1mr who could help with this? |
I've done that. Note that in many cases, PRs opened by bots won't run checks like this. You can work-around it by closing and re-opening. |
A build issue was introduced with the merging of this pr: #118
mockall 0.14.0requires min Rust version to be1.77.0.Alternatively, we can pin mockall to an older version. Not sure what the community think about Rust version compatibility. Note that
1.77.0is from 21 March 2024 (link)