Skip to content

Conversation

@fabriziodemaria
Copy link
Contributor

A build issue was introduced with the merging of this pr: #118

mockall 0.14.0 requires min Rust version to be 1.77.0.
Alternatively, we can pin mockall to an older version. Not sure what the community think about Rust version compatibility. Note that 1.77.0 is from 21 March 2024 (link)

Signed-off-by: Fabrizio Demaria <[email protected]>
@gemini-code-assist
Copy link

Summary of Changes

Hello @fabriziodemaria, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a recent build failure by bumping the minimum required Rust version for the project. This change ensures compatibility with updated dependencies, specifically mockall 0.14.0, which now mandates Rust 1.77.0. The project's configuration and documentation have been updated to reflect this new baseline, allowing for successful builds and continued development with the latest dependency versions.

Highlights

  • Minimum Supported Rust Version (MSRV) Update: The rust-version in Cargo.toml has been updated from 1.71.1 to 1.77.0 to address a build issue caused by the mockall 0.14.0 dependency, which requires Rust 1.77.0.
  • Documentation Alignment: The README.md file has been updated to reflect the new minimum Rust version, specifically in the version badge and the 'Requirements' section, ensuring consistency with the Cargo.toml change.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@fabriziodemaria fabriziodemaria marked this pull request as ready for review January 16, 2026 11:10
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly bumps the minimum supported Rust version to 1.77.0 in Cargo.toml to resolve a build issue with a dependency. The corresponding changes in README.md to update the version badge and requirements section are also included. I've suggested a small wording improvement in the README.md to more accurately reflect that the new Rust version is a strict requirement.

@erka
Copy link
Member

erka commented Jan 16, 2026

we need to change the Github settings and mark msrv action as required for merging PR to prevent this issue in future.

@beeme1mr who could help with this?

@toddbaert
Copy link
Member

we need to change the Github settings and mark msrv action as required for merging PR to prevent this issue in future.

@beeme1mr who could help with this?

I've done that.

Note that in many cases, PRs opened by bots won't run checks like this. You can work-around it by closing and re-opening.

@erenatas erenatas merged commit 7f74461 into open-feature:main Jan 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants