Introducing profile component parameter updatePreferencesModalEnabled#260
Merged
robinmolen merged 4 commits intomainfrom Dec 18, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 69.43% 69.40% -0.04%
==========================================
Files 290 290
Lines 10791 10796 +5
Branches 1744 1790 +46
==========================================
Hits 7493 7493
- Misses 3294 3299 +5
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sergei-maertens
approved these changes
Dec 18, 2025
Instead of calculating the validity of the parent component, we can simply pass it along from the parent to the child. The touched state in the `showPreferencesButton` logic doesn't serve any purpose. It was intended as "only show the button after human input", but this will (at this time) always be the case with the textfield subfield. The touched state could even cause issues/confusion with moving between form-steps. Where the user goes to a previously filled-in step to adjust their profile preferences, but the "update preferences" is for some reason hidden. Only after focus/blur will the button be shown. The logic should be: "does the field have a valid value for the intended digital address type?"
…onent parameters Using the `updatePreferencesModalEnabled` component parameter we can control if the "update digital address preferences" modal should be shown. The normal logic, of requiring a valid value, is still being used.
robinmolen
force-pushed
the
feature/5824-profile-non-authenticated-usage
branch
2 times, most recently
from
06f73a2 to
8f3f153
Compare
…profile component parameter
…ModalEnabled` set to false
robinmolen
force-pushed
the
feature/5824-profile-non-authenticated-usage
branch
from
8f3f153 to
e564448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes open-formulieren/open-forms#5824
Using the
updatePreferencesModalEnabledwe can control whether the "update preferences" button and modal will be shown along the profile component textfield subfield.In addition, the logic behind when the "update preferences" button appears is also updated. The
touchedstate caused issues in OF when moving between form-steps, where the "update preferences" button would not be shown because the field wasn'ttouched. To make the "update preferences" button appear,updatePreferencesModalEnabledneeds to be set totrue, and the textfield needs an valid digital address.