Open
Conversation
|
@water111 Can you fix the failing CI check? |
Member
|
the failing CI check doesn't need to be fixed, it's just a linter. But there are conflicts / likely a reason (lack of testing) for why this isn't merged yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the shadow renderer from MIPS2C to a new C++ implementation.
This solves the issue where the shadows get weird when the camera is inside the camera volume.
At this point, I'm not sure if the performance is better or not. The C++ is faster than the GOAL implementation by a lot, but there are more separate index buffer uploads to the GPU, giving more work to the graphics driver.
I'm not really sure that it matters since the meshes for shadow are so simple.