Skip to content

Comments

jak1: fix memcard screen on custom aspects#4116

Open
gratefulforest wants to merge 4 commits intoopen-goal:masterfrom
gratefulforest:memcard-scaling
Open

jak1: fix memcard screen on custom aspects#4116
gratefulforest wants to merge 4 commits intoopen-goal:masterfrom
gratefulforest:memcard-scaling

Conversation

@gratefulforest
Copy link
Contributor

@gratefulforest gratefulforest commented Jan 4, 2026

The particles for the grey memcard slots already had functions associated with them, so scaling the grey boxes was simply a matter of making use of those functions.

The memcard boxes expand and shrink with the aspect to resemble the PS2 behavior, where at 4:3 you get a short grey box and at 16:9 you get a long grey box.

Although I added scaling to the grey boxes, I wasn't satisfied with the way elements would "slip" as they would scale differently to each other. Mainly, the collectable counts and their totals slide more and more off from each other.

This is due to the game's use of integer offsets to decided UI placements; they were the right numbers for 4:3, but once you start to scale, they can slide more and more off. You can see this on a real PS2, where at 4:3, the collectibles are centered above the totals, and at 16:9, the collectibles are more right-aligned above the totals.

To fix this, I used the same text flags on the totals as the counts, so everything is snapped to each other.
Guards against (-> *pc-settings* use-vis?) ensure PS2 aspects remain untouched, and at PS2 16:9, you still get the original game bug of more right aligned counts.

memcard.mp4

@OpenGOALBot
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants