jak1: fix memcard screen on custom aspects#4116
Open
gratefulforest wants to merge 4 commits intoopen-goal:masterfrom
Open
jak1: fix memcard screen on custom aspects#4116gratefulforest wants to merge 4 commits intoopen-goal:masterfrom
gratefulforest wants to merge 4 commits intoopen-goal:masterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The particles for the grey memcard slots already had functions associated with them, so scaling the grey boxes was simply a matter of making use of those functions.
The memcard boxes expand and shrink with the aspect to resemble the PS2 behavior, where at 4:3 you get a short grey box and at 16:9 you get a long grey box.
Although I added scaling to the grey boxes, I wasn't satisfied with the way elements would "slip" as they would scale differently to each other. Mainly, the collectable counts and their totals slide more and more off from each other.
This is due to the game's use of integer offsets to decided UI placements; they were the right numbers for 4:3, but once you start to scale, they can slide more and more off. You can see this on a real PS2, where at 4:3, the collectibles are centered above the totals, and at 16:9, the collectibles are more right-aligned above the totals.
To fix this, I used the same text flags on the totals as the counts, so everything is snapped to each other.
Guards against
(-> *pc-settings* use-vis?)ensure PS2 aspects remain untouched, and at PS2 16:9, you still get the original game bug of more right aligned counts.memcard.mp4