Draft
Conversation
* Update go-libs url to `apache/cloudberry-go-libs` * Run go mod tidy to update go.mod and go.sum file * Update cluster_test.go * Remove the nil check for `failedCommand` in GenerateOutput function. After replacing greenplum-db/go-libs with apache/cloudberry-go-libs, the `FailedCommands` field type changed from `[]*cluster.ShellCommand` (pointer slice) to `[]cluster.ShellCommand` (value slice). In Go, struct values cannot be compared to nil, which caused the build error: ``` invalid operation: failedCommand == nil (mismatched types cluster.ShellCommand and untyped nil) ``` This nil check is no longer needed because: 1. Value-type slice elements are always valid structs, never nil 2. The NewRemoteOutput function only appends commands with non-nil errors to FailedCommands, so empty iterations won't occur
* Bump Apache `ORC` library to 1.7.11 In theory, we can bump up to 1.9.8. However pxf-hbase tests fail with new protobuf-3.x. For now, let's move fast rather than struggle in dependency hell. * Bump `ORC`'s dependencies to support `zstd` compression and tests for compression. Surprisingly, according to documentation, `zstd` should work well. However, old `aircompressor:0.8` doesn't have the ZStd codec, and attempting to use it will lead to an error.
Cherry-pick from 609435f
* Remove obsoleted files under `dev` dir * Move `dev/start_minio.bash` to `ci/docker/pxf-cbdb-dev/ubuntu/script/start_minio.bash` See: apache#48
ostinru
force-pushed
the
parquet-1.12.3
branch
from
f241af5 to
9edd2e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.