Conversation
darigovresearch
left a comment
There was a problem hiding this comment.
Hey @eslerm thanks for taking the time to make the pull request, can confirm that there is a broken link and this merge request would resolve the problem.
Does anyone with merge rights require any other changes for the pull request to be merged?
|
Can you check https://github.com/open-guides/og-aws/pull/799/files? Line 1814 needs to be joined with line 1815 with the domain name added. Looks like this on the readme currently: https://github.com/open-guides/og-aws#cloudformation-alternatives-and-lock-in |
|
@eslerm you can update your pull request to make the update you want, you can do that by clicking on the three dots then Could you also clarify what you mean by All URLs in your changes appear to work and have their domains |
|
The original patch is as intended. I will wait for projects maintainers to review. |
|
@eslerm sounds good. Do any maintainers require anything else for this pull request to be merged? |

No description provided.