Merged
Conversation
# Conflicts: # IDEAS/package.mo
Member
Author
This PR is ready to for review. |
jelgerjansen
requested changes
Mar 26, 2025
Contributor
jelgerjansen
left a comment
jelgerjansen
left a comment
There was a problem hiding this comment.
I would also remove the ".travis.yml" file as we don't use this for unit testing any more.
Apart from that (and the LIDEAS scripts that should still be tackled in another issue), the changes look good to me.
Member
Author
|
@jelgerjansen I have removed the travis.yml file as well. |
jelgerjansen
approved these changes
Mar 26, 2025
annadellisola
approved these changes
Apr 2, 2025
Contributor
annadellisola
left a comment
annadellisola
left a comment
There was a problem hiding this comment.
Seems fine to me. Thanks @lucasverleyen for addressing the issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1407 .
Not yet finished, but I already create a pull request to check the unit test status.