Merged
Conversation
…oved line annotations of dummy connections to avoid an overloaded diagram
This avoids a warning (tested with IDEAS.Buildings.Components.Examples.CavityInternalWall)
this is to be consistent with the naming hAbs_floor_a
The assert statements (checked at initialisation) do a first check if floors and ceilings connected two zones that are actually above/below eachother.
jelgerjansen
requested review from
annadellisola and
lucasverleyen
and removed request for
lucasverleyen
Contributor
annadellisola
left a comment
annadellisola
left a comment
There was a problem hiding this comment.
@jelgerjansen @kldjonge thank you for addressing the issue!
I have added only a minor comment regarding the reference to the issues addressed in the documentation.
While reviewing I also noticed an overlap of two models in the graphical view in IDEAS.Buildings.Components.Interfaces.ZoneBusVarMultiplicator. I have pushed the changes of the annotation to this branch
IDEAS/Buildings/Components/Interfaces/RectangularZoneTemplateInterface.mo
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #1402 and #1410