Skip to content

Issue1424 Missing mass flow connections box model #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jelgerjansen merged 2 commits into from
Feb 24, 2025
Merged

Issue1424 Missing mass flow connections box model #1425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d70ba97
added missing m_flow connections in IDEAS/Buildings/Components/Shadin…
Mathadon Feb 24, 2025
afeabe1
Add issue number to revision notes
jelgerjansen Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion IDEAS/Buildings/Components/Shading/Box.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ equation
33.3333},{-1.5,33.3333}}, color={0,0,127}));
connect(TDryBul, sideFins.TDryBul) annotation (Line(points={{40,-10},{3.5,-10},
{3.5,26.6667}}, color={0,0,127}));
connect(m_flow, sideFins.m_flow) annotation(
Line(points = {{40, -90}, {2, -90}, {2, 20}}, color = {0, 0, 127}));
connect(m_flow, overhang.m_flow) annotation(
Line(points = {{40, -90}, {4, -90}, {4, 60}}, color = {0, 0, 127}));
annotation (Diagram(coordinateSystem(preserveAspectRatio=false, extent={{-100,
-100},{100,200}})), Documentation(info="<html>
<p>
Expand All @@ -168,6 +172,11 @@ and IDEAS.Buildings.Components.Shading.SideFins.
</html>", revisions="<html>
<ul>
<li>
February 24, 2025 by Filip Jorissen:<br/>
Added missing m_flow connections.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1424\">#1424</a>.
</li>
<li>
December 15, 2022 by Filip Jorissen:<br/>
Bugfix for #1308.
</li>
Expand All @@ -190,4 +199,4 @@ Cleaned up implementation and documentation.
</html>"),
Icon(coordinateSystem(preserveAspectRatio=false, extent={{-100,-100},{100,
200}})));
end Box;
end Box;