Update interzonal airflow documentation#1449
Update interzonal airflow documentation#1449kldjonge wants to merge 2 commits intoopen-ideas:issue1340_DefaultWindSpeedfrom
Conversation
Revised and expanded the documentation for interzonal airflow and air infiltration modeling options. The updated text clarifies the behavior and configuration of the interzonalAirFlowType parameter, details the use of n50 and q50 values, and explains the differences between OnePort and TwoPorts options, including their recommended use cases and implementation details. Update interzonal airflow documentation Revised and expanded the documentation for interzonal airflow and air infiltration modeling options. The updated text clarifies the behavior and configuration of the interzonalAirFlowType parameter, details the use of n50 and q50 values, and explains the differences between OnePort and TwoPorts options, including their recommended use cases and implementation details.
The n50_computed parameter now directly uses n50_int, removing the conditional logic based on use_custom_n50 and setq50.allSurfacesCustom as this is allready done for n50_in (in the initital equation section)
|
@kldjonge there were some (unintended) changes in text format, so I'll manually apply your changes in the branch and close this PR. I noticed that you also made a change to the model, because of which the unit tests don't pass (change in number of states). Any idea how your change (n50 value related) affects this? |
|
Hmm, less or more states? Maybe there was another reason for using if statements twice that I am not aware of. Based on the modelica text, it just seemed redudant to have it for the n50-computed as well |
|
@kldjonge the unit tests are showing weird results... I propose to close this PR, and merge #1448 which includes the updated documentation for the unit tests (which pass). |
2 participants
Revised and expanded the documentation for interzonal airflow and air infiltration modeling options. The updated text clarifies the behavior and configuration of the interzonalAirFlowType parameter, details the use of n50 and q50 values, and explains the differences between OnePort and TwoPorts options, including their recommended use cases and implementation details.
@jelgerjansen