Skip to content

Conversation

@laraibg786
Copy link
Contributor

Following issues are resolved in the README of the project.

  • branch name for one of ci badges was incorrect
  • href for the documentation of dimred was pointing to documentation of diffcrash
  • naming convention of overview page of diffcrash was inconsistent.

Copy link
Contributor Author

@laraibg786 laraibg786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do change in diffcrash filenames in this PR. i dont want to break the docs since this will update the url in the readme while docs are only published for commits on main.

@codie3611
Copy link
Contributor

Hey, thanks man for the work! Changing the file name is fine. Docs are nothing critical.

Copy link
Contributor

@codie3611 codie3611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* update the link for dimred
* update the link for ci badge for `develop`
* make diffcrash url consistent
@laraibg786 laraibg786 force-pushed the docs/update_readme branch from 6dcb02b to 2f3eb07 Compare April 7, 2025 18:41
@laraibg786
Copy link
Contributor Author

I have squashed the commits. Please merge at your convenience.

@codie3611 codie3611 merged commit c2509bd into open-lasso-python:develop Apr 8, 2025
5 checks passed
@laraibg786 laraibg786 deleted the docs/update_readme branch April 8, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants