Skip to content

Conversation

@hishitashah
Copy link

@hishitashah hishitashah commented Nov 10, 2025

Important: Do not tick a checkbox if you haven’t performed its action.

Before Creating the Pull Request

  • Verify the changes are on a new branch other than master – it should say "compare: branch-name".
  • Start the pull request title with lowercase letters, e.g., add githubusername.md.
  • Add issue number to the end of the pull request title when applicable, e.g., update mi-faq.md (fixes #3264).

After Creating the Pull Request

  • Go to "Commits" tab, make sure the commit username is clickable and linked to your GitHub account correctly.
  • Review the "Files changed" tab to ensure there are no unnecessary files or changes included in the pull request.
  • Verify that the raw.githack preview link is included in the description.
    • Preview the MDwiki rendered changes using the raw.githack link. Ensure it displays as expected without any errors.
  • Drop a link to this pull request in our discord channel.

Description, Screenshots and/or Screencast

the changes here are me adding a markdown file consisting of information about me

fixes #3700

Raw.Githack Preview Link

https://raw.githack.com/hishitashah/hishitashah-open-learning-exchange.github.io/refs/heads/add-hishitashah-profile/pages/vi/profiles/hishitashah.md

@Mutugiii
Copy link
Member

Mutugiii commented Nov 11, 2025

Looks good, but the raw githack link you posted points to the raw markdown, it should point to the rendered, styled page

Also, no need for the fixes in the PR description since this doesn't address a specific issue

Copy link
Member

@Saby-Bishops Saby-Bishops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition! You might want to include a table layout here to present the details (like location, OS, etc.), it’ll improve readability and structure.

Copy link
Member

@Saby-Bishops Saby-Bishops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, try using a screenshot in the description next time, it’s quicker for reviewers to get context at a glance.

@Mutugiii Mutugiii changed the title add hishitashah profile create hishitashah profile Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants