Conversation
yochannah
left a comment
There was a problem hiding this comment.
This looks really good! I had two small comments before I will merge: can we update the alt text for the screenshots, so that if anyone has a screen reader, they have an idea what is in the image? An example for the first one in reviewer-instructions.md would be A page with a popup dialogue that says "you have chosen to accept this invitation. Do you want to continue?"
|
hah, I submitted too early. The second comment was to maybe not embed the dates in the text. I'm less sure about this one, to be honest, but I've noticed that going through text to update from OLS-3 to OLS-4 to OLS-5 is surprising time consuming. Where possible I've tried to say things like "when you sign up to OLS" rather than "when you sign up to OLS-6" to reduce admin burden. In this case, dates are useful, of course! Maybe have a separate file with a list of deadlines and link to it? Happy to be argued with on this one, and this comment shouldn't delay merging. The alt-text on above should! |
Starting with review rubric
Paz to add more files