Skip to content

[HF] drop set_seed usage from HF#365

Merged
mayank31398 merged 15 commits intomainfrom
n
Jan 30, 2026
Merged

[HF] drop set_seed usage from HF#365
mayank31398 merged 15 commits intomainfrom
n

Conversation

@mayank31398
Copy link
Collaborator

No description provided.

Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mayank31398, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request centralizes the random seed management within the lm_engine project by introducing a custom set_seed function. This change aims to reduce external dependencies by moving seed initialization logic from the transformers library into an internal utility. The new function ensures consistent seed setting across various random number generators, improving control and maintainability of reproducibility settings.

Highlights

  • Custom Seed Management: Introduced a new internal set_seed utility function within lm_engine.utils.random to manage random seeds across random, numpy, and torch.
  • Dependency Reduction: Replaced all existing usages of transformers.set_seed with the newly implemented internal lm_engine.utils.set_seed function, reducing reliance on the transformers library for this specific utility.
  • Code Refactoring: Refactored the instantiation of MegatronBatchSampler in lm_engine/data/megatron/__init__.py to improve code readability and maintainability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully refactors the set_seed functionality by moving its implementation from the transformers library to a new, internal utility module lm_engine/utils/random.py. This change centralizes seed management, reduces external dependencies for a core utility, and improves overall code modularity. The new set_seed function correctly initializes random seeds for random, numpy, and torch (including CUDA), ensuring reproducibility. All affected files have been updated to import the new utility. The changes are well-executed and enhance the project's maintainability.

@mayank31398 mayank31398 merged commit e3dad83 into main Jan 30, 2026
2 checks passed
@mayank31398 mayank31398 deleted the n branch January 30, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant