-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fixes #19944: updates operations to point to new tables #20945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
@heamioh changes looks good, once checks passes will merge it in |
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
Rules 🎸 1 action takenGitar Rules
2 rules not applicable. Show all rules by commenting OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Describe your changes:
Fixes Issue #19944
I worked on fixing the OpenMetadata info(), validate(), repair(), and checkConnection() operations because they used to reference only the old tables (DATABASE_CHANGE_LOG, via flyway) and not the new tables (SERVER_MIGRATION_SQL_LOGS and SERVER_CHANGE_LOGS). With the new changes, all the openmetadata-ops.sh commands now include functionality to handle the new tables. I tested these changes using unit tests, which I have included in the OpenMetadataOperationsTest.java file.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Bug fix
Summary by Gitar
infocommand displays native migration status fromSERVER_CHANGE_LOGwith metricsvalidatecommand checks for pending/failed migrations viaMigrationWorkflow.validateMigrationsForServer()repaircommand removes failed entries fromSERVER_CHANGE_LOGandSERVER_MIGRATION_SQL_LOGScheckConnectionnow verifies access to native migration tables alongside existing checksThis will update automatically on new commits.