Skip to content

Conversation

@heamioh
Copy link
Contributor

@heamioh heamioh commented Apr 23, 2025

Describe your changes:

Fixes Issue #19944

I worked on fixing the OpenMetadata info(), validate(), repair(), and checkConnection() operations because they used to reference only the old tables (DATABASE_CHANGE_LOG, via flyway) and not the new tables (SERVER_MIGRATION_SQL_LOGS and SERVER_CHANGE_LOGS). With the new changes, all the openmetadata-ops.sh commands now include functionality to handle the new tables. I tested these changes using unit tests, which I have included in the OpenMetadataOperationsTest.java file.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

Summary by Gitar

  • New CLI operations:
    • info command displays native migration status from SERVER_CHANGE_LOG with metrics
    • validate command checks for pending/failed migrations via MigrationWorkflow.validateMigrationsForServer()
    • repair command removes failed entries from SERVER_CHANGE_LOG and SERVER_MIGRATION_SQL_LOGS
  • Enhanced operation:
    • checkConnection now verifies access to native migration tables alongside existing checks

This will update automatically on new commits.


@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@heamioh heamioh changed the title Fixes Issue 19944: updates operations to point to new tables Fixes #19944: updates operations to point to new tables Apr 23, 2025
mohityadav766
mohityadav766 previously approved these changes Apr 24, 2025
@github-actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@mohityadav766
Copy link
Member

@heamioh changes looks good, once checks passes will merge it in

@github-actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@mohityadav766 mohityadav766 self-requested a review August 17, 2025 17:25
@github-actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@gitar-bot
Copy link

gitar-bot bot commented Jan 27, 2026

Rules 🎸 1 action taken

Gitar Rules

🎸 Summary Enhancement: Added technical summary to merged PR documenting new CLI operations

2 rules not applicable. Show all rules by commenting gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants