-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: properly escape quotes in CSV export for all quoted values #25357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 CI failure analysis for 301c3b4: Multiple Playwright E2E test suites failed across two CI jobs with CSV import validation errors showing incorrect row counts - tests expect specific numbers of passed/failed rows but receive different values, indicating systemic CSV import processing issues unrelated to this PR's CSV export fix.IssuePlaywright E2E tests failed in two separate CI jobs with a total of 10 test failures across multiple test suites: Job 1: playwright-ci-postgresql (1, 6) - 3 failures:
Job 2: playwright-ci-postgresql (2, 6) - 7 failures:
Root CauseAll failures share a common pattern in CSV import validation at expect(passedRow).toBe(status.passed);Observed mismatches:
DetailsThis failure is COMPLETELY UNRELATED to the current PR's changes. The PR modifies CSV export logic (adding quote escaping in Key observations:
Affected test files:
Root cause hypothesis: The bulk CSV import processing logic is failing to successfully process the expected number of rows. One or more rows that should pass validation are instead being marked as failed or not processed. This suggests:
Code Review ✅ ApprovedClean bug fix that properly escapes quotes in CSV export per RFC 4180. Well-tested with comprehensive coverage of edge cases. Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Describe your changes:
Fixed a bug where values containing commas, newlines, or in tags/domains columns were wrapped in quotes but inner quotes were not escaped, producing malformed CSV output
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
replaceAll(/"/g, '""')inCSV.utils.tsx:227per RFC 4180 standardThis will update automatically on new commits.