-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix: Automator patch issue - timestamp with seconds #25458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
🔍 CI failure analysis for b1c775f: All 14 CI job failures are caused by a missing 'safe to test' label on PR #25458, not by code issues. The workflows require this label before executing tests as a security measure.IssueAll CI jobs failed at the PR label verification step. None of the jobs reached actual test execution. Root CauseThe workflows use DetailsAffected Jobs (14 total):
Workflow Pattern:
Why This Label Exists: The Code Changes: The PR modifies Code Review 👍 Approved with suggestions 0 resolved / 1 findingsClean fix for datetime normalization with one minor unused import issue. More details 💡 1 suggestion💡 Quality: Unused import `Union`📄 ingestion/src/metadata/ingestion/models/patch_request.py:16 The Suggested fix: Remove from typing import Any, Dict, List, Optional, TupleWhat Works WellThe recursive datetime normalization function is well-designed: it properly handles all JSON types, correctly identifies datetime strings missing microseconds via a clear regex pattern, and preserves timezone information. The approach ensures compatibility with Java's SimpleDateFormat requirements. Rules 🎸 1 action takenGitar Rules
2 rules not applicable. Show all rules by commenting Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
| ) | ||
|
|
||
|
|
||
| def _normalize_datetime_strings(obj: Any) -> Any: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we have any time/datetime utilities module rather than having this on patch_request only. might be useful elsewhere
Summary by Gitar
_normalize_datetime_strings()to ensure ISO 8601 timestamps include microseconds (.000000) for Java SimpleDateFormat compatibility2026-01-19T18:08:41Z→2026-01-19T18:08:41.000000Z) before patch generationbuild_patch()inpatch_request.pyto wrap alljson.loads()calls with datetime normalizationThis will update automatically on new commits.