Skip to content

Fix: Charts not visible in explore tree panel #25487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aniketkatkar97 merged 17 commits into from
Feb 3, 2026
Merged

Fix: Charts not visible in explore tree panel #25487

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ffb3a7c
Initial plan
Copilot Jan 23, 2026
182d521
Remove CHART from notIncludeAggregationExploreTree and add test coverage
Copilot Jan 23, 2026
e233d62
Add CHART to Dashboard childEntities in explore tree
Copilot Jan 23, 2026
10b0a3d
Merge branch 'main' into copilot/fix-charts-visibility-issue
aniketkatkar97 Jan 23, 2026
daa72a0
Update test to verify charts visible in explore tree UI
Copilot Jan 23, 2026
e6f7eb2
Add CHART to getPluralizeEntityName and fix test selector
Copilot Jan 24, 2026
4a7ce1e
Remove manual timeout from ExploreTree test per Playwright guidelines
Copilot Jan 24, 2026
fc3b604
Merge branch 'main' into copilot/fix-charts-visibility-issue
aniketkatkar97 Jan 24, 2026
349e22d
Merge branch 'main' into copilot/fix-charts-visibility-issue
aniketkatkar97 Jan 24, 2026
008a819
Merge branch 'main' into copilot/fix-charts-visibility-issue
aniketkatkar97 Jan 24, 2026
6308f36
Add page reload to ensure chart data is visible in explore tree test
Copilot Jan 24, 2026
b04d214
Merge branch 'main' into copilot/fix-charts-visibility-issue
aniketkatkar97 Jan 27, 2026
09eb649
Merge branch 'main' into copilot/fix-charts-visibility-issue
aniketkatkar97 Feb 2, 2026
498a36c
Merge branch 'main' into copilot/fix-charts-visibility-issue
aniketkatkar97 Feb 2, 2026
aea084c
improve playwright for chart visibility
harsh-vador Feb 3, 2026
f776ddf
add support for charts on search entity
harsh-vador Feb 3, 2026
477ac51
Merge branch 'main' into copilot/fix-charts-visibility-issue
harsh-vador Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/ExploreTree.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { SidebarItem } from '../../constant/sidebar';
import { DataProduct } from '../../support/domain/DataProduct';
import { Domain } from '../../support/domain/Domain';
import { ApiEndpointClass } from '../../support/entity/ApiEndpointClass';
import { ChartClass } from '../../support/entity/ChartClass';
import { ContainerClass } from '../../support/entity/ContainerClass';
import { DashboardClass } from '../../support/entity/DashboardClass';
import { DashboardDataModelClass } from '../../support/entity/DashboardDataModelClass';
Expand Down Expand Up @@ -290,6 +291,7 @@ test.describe('Explore page', () => {
const glossary = new Glossary();
const glossaryTerm = new GlossaryTerm(glossary);
const dashboard = new DashboardClass();
const chart = new ChartClass();
const storedProcedure = new StoredProcedureClass();
const pipeline = new PipelineClass();
const container = new ContainerClass();
Expand Down Expand Up @@ -319,6 +321,7 @@ test.describe('Explore page', () => {
await glossary.create(apiContext);
await glossaryTerm.create(apiContext);
await dashboard.create(apiContext);
await chart.create(apiContext);
await storedProcedure.create(apiContext);
await pipeline.create(apiContext);
await container.create(apiContext);
Expand Down Expand Up @@ -348,6 +351,7 @@ test.describe('Explore page', () => {
await glossaryTerm.delete(apiContext);
await glossary.delete(apiContext);
await dashboard.delete(apiContext);
await chart.delete(apiContext);
await storedProcedure.delete(apiContext);
await pipeline.delete(apiContext);
await container.delete(apiContext);
Expand Down Expand Up @@ -402,6 +406,50 @@ test.describe('Explore page', () => {
await validateBucketsForIndex(page, 'all');
});

test('Verify charts are visible in explore tree', async ({ page }) => {
await page.waitForLoadState('networkidle');
Copy link

@gitar-bot gitar-bot bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed both networkidle waits. The test now relies on explicit API response waits and Playwright's built-in auto-waiting.

await page.waitForSelector('[data-testid="loader"]', {
state: 'detached',
});

const dashboardNode = page.getByTestId('explore-tree-title-Dashboards');
await expect(dashboardNode).toBeVisible();

const expandResponse = page.waitForResponse(
(resp) =>
resp.url().includes('/api/v1/search/query') &&
resp.url().includes('index=dataAsset')
);

await page
.locator('div')
.filter({ hasText: /^Dashboards$/ })
.locator('svg')
.first()
.click();

await expandResponse;
await page.waitForLoadState('networkidle');

const chartTreeNode = page.locator('[data-testid*="explore-tree-title"]', {
hasText: 'Charts',
});
await expect(chartTreeNode).toBeVisible();

const chartClickResponse = page.waitForResponse(
(resp) =>
resp.url().includes('/api/v1/search/query') &&
resp.url().includes('index=dataAsset')
);

await chartTreeNode.click();
await chartClickResponse;

await expect(
page.getByTestId('search-dropdown-Data Assets')
).toContainText('Data Assets: chart');
});

DATA_ASSETS.forEach((asset) => {
test.fixme(
`Check listing of ${asset.key} when sort is descending`,
Expand Down
1 change: 1 addition & 0 deletions openmetadata-ui/src/main/resources/ui/src/utils/EntityUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2719,6 +2719,7 @@ export const getPluralizeEntityName = (entityType?: string) => {
[EntityType.PIPELINE]: t('label.pipeline-plural'),
[EntityType.CONTAINER]: t('label.container-plural'),
[EntityType.DASHBOARD]: t('label.dashboard-plural'),
[EntityType.CHART]: t('label.chart-plural'),
[EntityType.STORED_PROCEDURE]: t('label.stored-procedure-plural'),
[EntityType.MLMODEL]: t('label.ml-model-plural'),
[EntityType.DASHBOARD_DATA_MODEL]: t('label.data-model-plural'),
Expand Down
3 changes: 2 additions & 1 deletion openmetadata-ui/src/main/resources/ui/src/utils/SearchClassBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ class SearchClassBase {
childEntities: [
EntityType.DASHBOARD_DATA_MODEL,
EntityType.DASHBOARD,
EntityType.CHART,
],
},
icon: DashboardIcon,
Expand Down Expand Up @@ -683,7 +684,7 @@ class SearchClassBase {
}

public notIncludeAggregationExploreTree() {
return [EntityType.CHART, EntityType.INGESTION_PIPELINE];
return [EntityType.INGESTION_PIPELINE];
}

public staticKeysHavingCounts(): string[] {
Expand Down
Loading