Skip to content

Conversation

@Rohit0301
Copy link
Contributor

@Rohit0301 Rohit0301 commented Jan 25, 2026

Addressed recognizer UI feedbacks

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • UserPopOverCard refactor:
    • Simplified usage with showUserName and displayName props in TaskTabNew.component.tsx
    • Fixed user identification by separating userName (.name for lookup) from displayName (getEntityName() for display)
    • Adjusted profile picture width from 24px to 22px using profileWidth prop
  • MUIAutocomplete enhancement:
    • Added custom renderOption with theme.palette.grey[700] color and h6 font weight for dropdown options
    • Fixed bug to handle both string and object options using option?.label ?? option pattern
    • Added padding and border radius styling for better visual appearance
  • Button color standardization:
    • Changed cancel buttons from blue (allShades.blue[600]) to neutral grey (grey[700]) in ClassificationFormDrawer.tsx and TagFormDrawer.tsx

This will update automatically on new commits.


@gitar-bot
Copy link

gitar-bot bot commented Jan 25, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Clean refactor that properly separates userName (for API lookup) from displayName (for UI rendering). Previous finding about wrong identifier has been addressed. No new issues found.

✅ 1 resolved
Bug: Potential wrong identifier used for UserPopOverCard userName

📄 openmetadata-ui/src/main/resources/ui/src/components/Entity/Task/TaskTab/TaskTabNew.component.tsx
In the assignee section refactor, the original code used taskThread?.task?.assignees[0].name for the userName prop (which is used for user lookup/identification) and getEntityName(taskThread?.task?.assignees[0]) separately for display purposes.

The refactored code now uses getEntityName(taskThread?.task?.assignees[0]) for the userName prop. If getEntityName returns a display name (e.g., "John Doe") that differs from the actual username identifier (e.g., "jdoe"), the UserPopOverCard may fail to correctly look up the user or navigate to the wrong user profile.

Original code:

userName={taskThread?.task?.assignees[0].name ?? ''}
// ...
{getEntityName(taskThread?.task?.assignees[0])}

New code:

userName={getEntityName(taskThread?.task?.assignees[0])}

Suggested fix: Keep using .name for the userName prop since it's used for user identification:

<UserPopOverCard
  showUserName
  profileWidth={22}
  userName={taskThread?.task?.assignees[0].name ?? ''}
/>

Or verify that getEntityName always returns the username identifier when passed an assignee object.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.77% (55195/83915) 44.76% (28461/63579) 47.72% (8680/18188)

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants