-
Notifications
You must be signed in to change notification settings - Fork 1.6k
playwright: fix AUT playwright test for test cases #25526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…reliability in data quality import/export tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adjusts Playwright Data Quality E2E utilities/specs to make tests more robust (primarily around table metadata/FQN usage) and tidies up spec formatting.
Changes:
- Added explicit validation for required table metadata/FQN before using it in Playwright helpers.
- Refactored/normalized formatting in Data Quality permission specs and tightened API validation flows.
- Added a local
getFqnhelper + minor stability tweaks (e.g., conditionaltest.slow()) in bulk import/export specs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| openmetadata-ui/src/main/resources/ui/playwright/utils/testCases.ts | Adds guards for required table metadata/FQN before asserting breadcrumbs / building test-suite strings. |
| openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/TestDefinitionPermissions.spec.ts | Formatting cleanup and small robustness tweaks around system test definition lookup. |
| openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/TestCaseImportExportBasic.spec.ts | Adds getFqn helper and minor stability/formatting improvements for import/export permission and flow tests. |
.../src/main/resources/ui/playwright/e2e/Features/DataQuality/TestDefinitionPermissions.spec.ts
Show resolved
Hide resolved
🔍 CI failure analysis for 3e0f5c6: CI failure persists after retry: ServiceCreationPermissions.spec.ts consistently fails in both attempts, unrelated to PR's Data Quality changes.IssueThe CI job Root CauseConsistent Failure in Both Attempts:
Failed Test:
The failure is consistent and reproducible, not a random flaky test. The element DetailsUnrelated to PR Changes: This PR only modifies Data Quality test files:
The failing test Flaky Tests (Environmental Issues):
Pattern Analysis:
Code Review 👍 Approved with suggestions 0 resolved / 1 findingsGood test reliability improvements with proper null safety checks. One minor edge case where displayName validation could be more complete. 💡 Edge Case: Incomplete null check: displayName is checked but not validated📄 openmetadata-ui/src/main/resources/ui/playwright/utils/testCases.ts:738 The code destructures If Suggested fix: if (!service || !database || !databaseSchema || !displayName) {
throw new Error(
`Table metadata (service, database, databaseSchema, or displayName) is missing for ${table.entity.name}`
);
}Or alternatively, if Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



playwright: fix AUT playwright test for test cases
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
getFqn()helper with null safety checks forfullyQualifiedNameinTestCaseImportExportBasic.spec.tstest.slow()handling and explicit loader detachment waits reduce flakinessservice,database,databaseSchema) intestCases.tsprevents runtime errorsTestDefinitionPermissions.spec.tsThis will update automatically on new commits.