-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix design issues with input/output port feature #25551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
openmetadata-ui/src/main/resources/ui/src/locale/languages/de-de.json
Outdated
Show resolved
Hide resolved
🔍 CI failure analysis for c43fae7: CI run shows 5/6 jobs failing with 248 total test failures. Job 5 has highest failure count (110) but ALL failures are in entity CRUD operations. InputOutputPorts maintains 100% pass rate.IssuePlaywright CI run 21538604278 on commit c43fae7 has 5 of 6 jobs failing (Jobs 2, 3, 4, 5, and 6). Job 5 has the highest failure count with 110 failures. Root CauseInfrastructure and timing issues causing test timeouts in unrelated features. The Input/Output Ports feature code is definitively correct. Job 5 (62069225577) - NEWLY ANALYZED - HIGHEST FAILURE COUNT
Failure Breakdown:
Summary of All 5 Failing JobsJob 2 (62069225581): 41 failures, NO InputOutputPorts failures Total: 248 test failures across 5 jobs, ZERO InputOutputPorts failures DetailsCritical Evidence - InputOutputPorts Tests: Why Job 5's 110 failures are NOT related to this PR:
CI Run Progression:
Failure Categories (All 5 Jobs):
Definitive Evidence:
ConclusionJob 5 represents the worst-case scenario with 110 failures, but NONE are related to InputOutputPorts. All failures are in entity CRUD operation infrastructure (Owner, Glossary Term, Tag, Domain operations) affecting various entity types completely unrelated to the Input/Output Ports feature. Code Review ✅ Approved 2 resolved / 2 findingsWell-structured UI/UX improvements for Input/Output Ports with layout fixes, user guidance enhancements, asset removal warnings, query filtering for output ports, and comprehensive i18n translations across 22 locales. No issues found. ✅ 2 resolved✅ Bug: Unused title prop added to useAssetSelectionContent interface
✅ Quality: i18n strings not translated for non-English locales
Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
InputOutputPortsTab.component.tsxusing flexbox withflex: 1andminHeight: 0for proper overflow handlingassetCountprop throughout component hierarchy to disable port addition buttons when no assets existfitViewprop and adding manualzoomTo(0.4)controlPortsLineageView.component.tsxThis will update automatically on new commits.