Skip to content

Conversation

@siddhant1
Copy link
Member

@siddhant1 siddhant1 commented Jan 27, 2026

Describe your changes:

Screenshot 2026-01-27 at 5 46 42 PM Screenshot 2026-01-27 at 5 46 53 PM Screenshot 2026-01-27 at 5 46 59 PM

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Layout refactor:
    • Fixed responsive height issues in InputOutputPortsTab.component.tsx using flexbox with flex: 1 and minHeight: 0 for proper overflow handling
  • User guidance enhancement:
    • Added assetCount prop throughout component hierarchy to disable port addition buttons when no assets exist
    • Added contextual empty state messages with proper translations across 22 locale files
  • Lineage view improvements:
    • Fixed React Flow zoom behavior by removing conflicting fitView prop and adding manual zoomTo(0.4) control
    • Updated fullscreen button styling with consistent border and icon colors in PortsLineageView.component.tsx

This will update automatically on new commits.


@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot
Copy link

gitar-bot bot commented Jan 31, 2026

🔍 CI failure analysis for c43fae7: CI run shows 5/6 jobs failing with 248 total test failures. Job 5 has highest failure count (110) but ALL failures are in entity CRUD operations. InputOutputPorts maintains 100% pass rate.

Issue

Playwright CI run 21538604278 on commit c43fae7 has 5 of 6 jobs failing (Jobs 2, 3, 4, 5, and 6). Job 5 has the highest failure count with 110 failures.

Root Cause

Infrastructure and timing issues causing test timeouts in unrelated features. The Input/Output Ports feature code is definitively correct.

Job 5 (62069225577) - NEWLY ANALYZED - HIGHEST FAILURE COUNT

  • 110 test failures + 8 flaky tests (eventually passed)
  • Auth setup: PASSED
  • NO InputOutputPorts tests failed
  • 181 total tests passed
  • 260 tests did not run (shard distribution)

Failure Breakdown:

  1. EntityDataConsumer.spec.ts (58 failures) - Permission-based entity operations:

    • Owner and Glossary Term operations for 15 entity types
    • ApiEndpoint, Table, Dashboard, Pipeline, Topic, MlModel, Container, SearchIndex, DashboardDataModel, Metric, Directory, File, Spreadsheet, Worksheet, Store Procedure
    • All failures in entity CRUD infrastructure, NOT InputOutputPorts
  2. EntityDataSteward.spec.ts (36 failures) - Data Steward role operations:

    • Owner and Glossary Term operations for 12 entity types
    • ApiEndpoint, Table, Dashboard, Pipeline, Topic, MlModel, Container, SearchIndex, DashboardDataModel, Metric, Directory, Store Procedure
    • All failures in permission-based entity operations
  3. Entity.spec.ts (16 failures) - Domain and Owner operations:

    • Dashboard (4), MlModel (4), Dashboard Data Model (4), Directory (4)
    • Domain propagation, Owner assignments

Summary of All 5 Failing Jobs

Job 2 (62069225581): 41 failures, NO InputOutputPorts failures
Job 3 (62069225569): 31 failures + 16 flaky, NO InputOutputPorts failures
Job 4 (62069225589): 41 failures + 21 flaky, NO InputOutputPorts failures
Job 5 (62069225577): 110 failures + 8 flaky, NO InputOutputPorts failures
Job 6 (62069225587): 25 failures + 14 flaky, ALL 37 InputOutputPorts tests PASSED

Total: 248 test failures across 5 jobs, ZERO InputOutputPorts failures

Details

Critical Evidence - InputOutputPorts Tests:

Job 6: ALL 37 InputOutputPorts tests PASSED (100% success rate)
Jobs 2, 3, 4, 5: NO InputOutputPorts test failures

Total: 16+ jobs tested across 4 CI runs
Result: ZERO InputOutputPorts failures

Why Job 5's 110 failures are NOT related to this PR:

  1. Zero InputOutputPorts failures: None of the 110 failures involve InputOutputPorts tests

  2. All failures in Entity CRUD infrastructure:

    • 58 failures in EntityDataConsumer (permission-based operations)
    • 36 failures in EntityDataSteward (data steward role operations)
    • 16 failures in Entity.spec (domain/owner operations)
    • All are Owner, Glossary Term, Tag, Domain operations for various entity types
  3. Pattern consistency: Same types of failures across multiple entity types indicates infrastructure/timing issues, not feature bugs

  4. Unrelated entity types: Failures in Dashboard, MlModel, Pipeline, Topic, Container, SearchIndex, DashboardDataModel, Metric, Directory, File, Spreadsheet, Worksheet - none related to InputOutputPorts

  5. Flaky tests: 59+ flaky tests eventually passed across all 5 jobs

CI Run Progression:

  1. Commit 2e32043: 6/6 jobs failed (100%), 87+ failures
  2. Commit 2b365b7: 4/6 jobs failed (67%), 90+ failures
  3. Commit 1bc51c6: 4/6 jobs failed (67%), 110+ failures
  4. Commit c43fae7: 5/6 jobs failed (83%), 248 failures

Failure Categories (All 5 Jobs):

  • Entity CRUD operations: 127+ failures (Jobs 5, 2, 4, 6)
  • Custom properties: 21 failures (Job 4)
  • Pagination: 15 failures (Job 3)
  • TableSearch: 8 failures (Job 3)
  • Domain/Data Products: 11+ failures
  • Glossary: 10+ failures
  • Other: 56+ failures
  • InputOutputPorts: 0 failures

Definitive Evidence:

  • 100% InputOutputPorts test pass rate across all 4 CI runs
  • 16+ jobs tested, 37+ test cases, ZERO failures
  • Auth setup: 100% success maintained
  • Job 5's 110 failures ALL in entity CRUD infrastructure
  • 59+ flaky tests indicate infrastructure/timing issues

Conclusion

Job 5 represents the worst-case scenario with 110 failures, but NONE are related to InputOutputPorts. All failures are in entity CRUD operation infrastructure (Owner, Glossary Term, Tag, Domain operations) affecting various entity types completely unrelated to the Input/Output Ports feature.

Code Review ✅ Approved 2 resolved / 2 findings

Well-structured UI/UX improvements for Input/Output Ports with layout fixes, user guidance enhancements, asset removal warnings, query filtering for output ports, and comprehensive i18n translations across 22 locales. No issues found.

✅ 2 resolved
Bug: Unused title prop added to useAssetSelectionContent interface

📄 openmetadata-ui/src/main/resources/ui/src/components/DataAssets/AssetsSelectionModal/useAssetSelectionContent.tsx:100
The title prop was added to AssetSelectionContentProps interface in useAssetSelectionContent.tsx, but looking at the diff, this prop is never destructured or used within the useAssetSelectionContent function. The prop is only actually used in useAssetSelectionDrawer.tsx.

While this doesn't cause runtime issues, it adds unnecessary type definitions that may confuse future developers and suggests the interface is doing more than the actual implementation.

Suggestion: Either:

  1. Remove the title prop from AssetSelectionContentProps if it's not needed there
  2. If the prop is intended to be used by the content component, implement the actual usage
Quality: i18n strings not translated for non-English locales

📄 openmetadata-ui/src/main/resources/ui/src/locale/languages/es-es.json:2555 📄 openmetadata-ui/src/main/resources/ui/src/locale/languages/fr-fr.json:2555 📄 openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-cn.json:2555
The three new i18n message keys (no-assets-for-input-ports, no-assets-for-output-ports, no-assets-for-ports-lineage) have been added to all 22 locale files, but only the English (en-us.json) version contains actual translations. All other locale files (Spanish, French, German, Chinese, etc.) contain the English text instead of translations in their respective languages.

This means non-English users will see English text for these messages, which breaks the localization experience.

Impact: Users with non-English locale settings will see English messages mixed with their native language, creating an inconsistent UX.

Suggestion: Either:

  1. Provide proper translations for all supported locales
  2. If translations will be done separately, add a tracking comment or TODO noting that translations are pending
  3. Consider using a placeholder translation key approach if the codebase supports it

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants