-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove Column Bulk Operations from Preferences and standardize learning icon #25552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e719d7 to
0c0954c
Compare
🔍 CI failure analysis for 0c0954c: Playwright test failure in GlossaryImportExport is unrelated to PR changes and appears to be a flaky test with timing issues.IssuePlaywright test Root CauseThe test expects a data grid header element ( DetailsThis failure is unrelated to the PR changes because:
The test is attempting to validate CSV import with invalid parent references, which has no connection to settings menu changes or icon standardization. Code Review ✅ ApprovedClean removal of Column Bulk Operations menu item and SVG standardization. No issues found - straightforward feature removal and icon improvement. Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
Changes:
IconImportimport fromGlobalSettingsClassBase.tslearning-colored.svgicon: migrated from fixed dimensions (72x72) to flexible viewBox (89x89) with proportionally adjusted coordinatesTechnical Details:
GlobalSettingsClassBase.ts: Removed 8 lines including the Column Bulk Operations menu configuration and its icon importlearning-colored.svg: Changed SVG attributes fromwidth="72" height="72"toviewBox="0 0 89 89"and scaled all internal coordinates (+8.5 units) to maintain visual appearance