Skip to content

Conversation

@Rohit0301
Copy link
Contributor

@Rohit0301 Rohit0301 commented Jan 27, 2026

Describe your changes:

Fixes

I worked on ... because ...

Screenshot 2026-01-27 at 6 08 31 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

Changes:

  • Removed the "Column Bulk Operations" menu item from Global Settings → Preferences section
  • Removed the unused IconImport import from GlobalSettingsClassBase.ts
  • Standardized learning-colored.svg icon: migrated from fixed dimensions (72x72) to flexible viewBox (89x89) with proportionally adjusted coordinates

Technical Details:

  • Updated GlobalSettingsClassBase.ts: Removed 8 lines including the Column Bulk Operations menu configuration and its icon import
  • Updated learning-colored.svg: Changed SVG attributes from width="72" height="72" to viewBox="0 0 89 89" and scaled all internal coordinates (+8.5 units) to maintain visual appearance

@Rohit0301 Rohit0301 force-pushed the fixed-column-bulk-edit-icon branch from 6e719d7 to 0c0954c Compare January 27, 2026 12:40
@gitar-bot gitar-bot bot changed the title Updated the Column bulk edit icon Remove Column Bulk Operations from Preferences and standardize learning icon Jan 27, 2026
@gitar-bot
Copy link

gitar-bot bot commented Jan 27, 2026

🔍 CI failure analysis for 0c0954c: Playwright test failure in GlossaryImportExport is unrelated to PR changes and appears to be a flaky test with timing issues.

Issue

Playwright test Import validation - invalid parent reference failed in the playwright-ci-postgresql (6, 6) job.

Root Cause

The test expects a data grid header element (.rdg-header-row) to be visible after CSV import, but the element was not found within the 5-second timeout. The test failed on both the initial run and retry attempt.

Details

This failure is unrelated to the PR changes because:

  1. Scope Mismatch: This PR only modifies:

    • learning-colored.svg - Icon viewBox standardization
    • GlobalSettingsClassBase.ts - Removes Column Bulk Operations menu item

    Neither change affects glossary import/export functionality.

  2. Flakiness Pattern: The test run showed 9 flaky tests, including two other GlossaryImportExport tests:

    • "Glossary Bulk Import Export"
    • "Import validation - missing required fields"
  3. Test Results: 523 tests passed, indicating the codebase is generally healthy.

  4. Error Nature: The failure is a timing issue (element not found within timeout), not a functional error caused by code changes.

The test is attempting to validate CSV import with invalid parent references, which has no connection to settings menu changes or icon standardization.

Code Review ✅ Approved

Clean removal of Column Bulk Operations menu item and SVG standardization. No issues found - straightforward feature removal and icon improvement.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.8% (55632/84545) 44.84% (28707/64015) 47.68% (8740/18329)

@sonarqubecloud
Copy link

@Rohit0301 Rohit0301 merged commit 9842342 into main Jan 27, 2026
22 of 23 checks passed
@Rohit0301 Rohit0301 deleted the fixed-column-bulk-edit-icon branch January 27, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants