Conversation
...-integration-tests/src/test/java/org/openmetadata/it/tests/WorkflowDefinitionResourceIT.java
Show resolved
Hide resolved
Code Review ✅ Approved 1 resolved / 1 findingsSolid test reliability improvements — Thread.sleep replaced with Awaitility polling, proper null-safety added, and test isolation correctly configured. The previously flagged missing waitForWorkflowDeployment call has been resolved. ✅ 1 resolved✅ Bug: Missing waitForWorkflowDeployment before trigger in MultiEntityPeriodicQuery test
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
Thread.sleep()with Awaitilityawait()polling inWorkflowDefinitionResourceITfor deterministic async verificationwaitForWorkflowDeployment()andwaitForEntityIndexedInSearch()ensure workflows deploy and entities index before assertionsmax_allowed_packetto 64M inTestSuiteBootstrapto handle large workflow definitions@Isolatedand@TestMethodOrderannotations to prevent parallel execution race conditionsThis will update automatically on new commits.