Skip to content

Fix workflow tests#25948

Merged
harshach merged 2 commits intomainfrom
fix_tests
Feb 18, 2026
Merged

Fix workflow tests#25948
harshach merged 2 commits intomainfrom
fix_tests

Conversation

@harshach
Copy link
Collaborator

@harshach harshach commented Feb 18, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test reliability improvements:
    • Replaced Thread.sleep() with Awaitility await() polling in WorkflowDefinitionResourceIT for deterministic async verification
  • New helper methods:
    • waitForWorkflowDeployment() and waitForEntityIndexedInSearch() ensure workflows deploy and entities index before assertions
  • MySQL configuration:
    • Increased max_allowed_packet to 64M in TestSuiteBootstrap to handle large workflow definitions
  • Test execution ordering:
    • Added @Isolated and @TestMethodOrder annotations to prevent parallel execution race conditions

This will update automatically on new commits.


@gitar-bot
Copy link

gitar-bot bot commented Feb 18, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Solid test reliability improvements — Thread.sleep replaced with Awaitility polling, proper null-safety added, and test isolation correctly configured. The previously flagged missing waitForWorkflowDeployment call has been resolved.

✅ 1 resolved
Bug: Missing waitForWorkflowDeployment before trigger in MultiEntityPeriodicQuery test

📄 openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/WorkflowDefinitionResourceIT.java:2307
The test_PeriodicBatchWorkflowWithMultiEntityAndFilters test creates a workflow and immediately triggers it at line 2307 without calling waitForWorkflowDeployment(). All other tests in this PR that create-then-trigger a workflow now include this wait step. This test also removed the Thread.sleep(10000) that previously waited for entity indexing (between entity creation and workflow trigger) but did not replace it with waitForEntityIndexedInSearch().

This means the same race conditions this PR aims to fix — workflow not yet deployed when triggered, and entities not yet indexed when the workflow runs — still exist in this test method.

Additionally, storeStageStatus is still true on line 2283 for this workflow, which is inconsistent with the other 3 workflow definitions changed to false in this PR to address MySQL packet size issues.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments