[Chore] add initial support for PEP517 builds#2154
Open
abn wants to merge 1 commit intoopen-mmlab:mainfrom
Open
[Chore] add initial support for PEP517 builds#2154abn wants to merge 1 commit intoopen-mmlab:mainfrom
abn wants to merge 1 commit intoopen-mmlab:mainfrom
Conversation
This change adds initial pyproject.toml file to allow PEP517 builds.
Author
|
The lint failures seem to be originating from a file that was not touched in the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
An issue was raised at python-poetry/poetry#9707 indicating that PEP517 builds of this project was failing due to missing build system requirement declaration.
Modification
This change adds initial pyproject.toml file to allow PEP517 builds.
Use cases
The project can now be build correctly by PEP517 front ends. For example, with this change the following command will work.
python3.8 -m pip wheel 'git+https://github.com/open-mmlab/mmagic.git'You can test the changes using the following command.
python3.8 -m pip wheel 'git+https://github.com/open-mmlab/mmagic.git@refs/pull/2154/head'Checklist
Submitting this pull request means that,
Before PR:
After PR: