v2.x: PSM/PSM2: Disable signal handler hijacking by default

[jsquyres]

Per discussion on open-mpi/ompi#1767 (and some
subsequent phone calls and off-issue email discussions), the PSM
library is hijacking signal handlers by default. Specifically: unless
the environment variables IPATH_NO_BACKTRACE=1 (for PSM / Intel
TrueScale) is set, the library constructor for this library will
hijack various signal handlers for the purpose of invoking its own
error reporting mechanisms.

This may be a bit surprising, but is not a problem, per se. The
real problem is that older versions of at least the PSM library do not
unregister these signal handlers upon being unloaded from memory.
Hence, a segv can actually result in a double segv (i.e., the original
segv and then another segv when the now-non-existent signal handler is
invoked).

This PSM signal hijacking subverts Open MPI's own signal reporting
mechanism, which may be a bit surprising for some users (particularly
those who do not have Intel TrueScale). As such, we disable it by
default so that Open MPI's own error-reporting mechanisms are used.

Additionally, there is a typo in the library destructor for the PSM2
library that may cause problems in the unloading of its signal
handlers. This problem can be avoided by setting HFI_NO_BACKTRACE=1
(for PSM2 / Intel OmniPath).

This is further compounded by the fact that the PSM / PSM2 libraries
can be loaded by the OFI MTL and the usNIC BTL (because they are
loaded by libfabric), even when there is no Intel networking hardware
present. Having the PSM/PSM2 libraries behave this way when no Intel
hardware is present is clearly undesirable (and is likely to be fixed
in future releases of the PSM/PSM2 libraries).

This commit sets the following two environment variables to disable
this behavior from the PSM/PSM2 libraries (if they are not already
set):

• IPATH_NO_BACKTRACE=1
• HFI_NO_BACKTRACE=1

If the user has set these variables before invoking Open MPI, we will
not override their values (i.e., their preferences will be honored).

Signed-off-by: Jeff Squyres [email protected]

(cherry picked from commit open-mpi/ompi@5071602)

Reviewed by @rhc54 @matcabral

@hppritcha When CI finishes, good to go.

[lanl-ompi]

Test FAILed.

[mellanox-github]

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1770/ for details.

[rhc54]

I'll fix this - simple missing include statement. will then resubmit using my branch since i don't have write privileges on @jsquyres

[hppritcha]

thanks @rhc54
so you'll open a new PR correct?

[rhc54]

yes - i'll just bring over the text from here

[rhc54]

replaced with #1224

[lanl-ompi]

Test FAILed.