v2.0.2: btl tcp fix help messages

[jsquyres]

From open-mpi/ompi#2050:

We commonly see messages on the users list where a peer has hung up because it has crashed. Instead of having just a BTL_ERROR message, make this a real opal_show_help() message that tells the user that the peer unexpectedly hung up, and they should look into why that peer hung up.

Signed-off-by: Jeff Squyres [email protected]

There's a second commit on this PR that disentangles two help messages that accidentally look like they got entangled.

[jsquyres]

@bosilca If you could verify this PR for v2.x, that'd be great. Thanks.

[bosilca]

👍

[mellanox-github]

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/2156/ for details.

[jsquyres]

@rhc54 Getting a PMIx bind failure on v2.x in Mellanox Jenkins (unrelated to this PR):

10:16:10 + taskset -c 10,11 timeout -s SIGSEGV 15m /var/lib/jenkins/jobs/gh-ompi-release-pr/workspace/ompi_install1/bin/mpirun -np 8 -bind-to none -mca btl_openib_if_include mlx4_0:1 -x MXM_RDMA_PORTS=mlx4_0:1 -x UCX_NET_DEVICES=mlx4_0:1 -x UCX_TLS=rc,cm -mca pml ob1 -mca btl self,openib taskset -c 10,11 /var/lib/jenkins/jobs/gh-ompi-release-pr/workspace/ompi_install1/examples/hello_c
10:16:10 [jenkins03:19613] [[30694,0],0] ORTE_ERROR_LOG: Error in file orted/pmix/pmix_server.c at line 254
10:16:10 [jenkins03:19613] [[30694,0],0] ORTE_ERROR_LOG: Error in file ess_hnp_module.c at line 656
10:16:10 --------------------------------------------------------------------------
10:16:10 It looks like orte_init failed for some reason; your parallel process is
10:16:10 likely to abort.  There are many reasons that a parallel process can
10:16:10 fail during orte_init; some of which are due to configuration or
10:16:10 environment problems.  This failure appears to be an internal failure;
10:16:10 here's some additional information (which may only be relevant to an
10:16:10 Open MPI developer):
10:16:10 
10:16:10   pmix server init failed
10:16:10   --> Returned value Error (-1) instead of ORTE_SUCCESS
10:16:10 --------------------------------------------------------------------------
10:16:10 src/server/pmix_server_listener.c:92 bind() failed

[jsquyres]

@hppritcha Good to go

[jsquyres]

bot:mellanox:retest

[hppritcha]

the mlnx jenkins failure doesn't have anything to do with this, merging.

[mellanox-github]

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/2167/ for details.