Skip to content

Conversation

naughtont3
Copy link

Tests for MPI_Remove_error_{class,code,string} added in MPI 4.1

Notes:

  • autotooling to dynamically check for MPI_Remove_error_* fns Note: auto-tooling is mostly copy/paste from Jeff's status test

  • if symbols not found, skips. However, if we detect we have a new enough MPI >= 4.1, we will print msg that these should exist.

Tests for MPI_Remove_error_{class,code,string} added in MPI 4.1

Notes:
- autotooling to dynamically check for MPI_Remove_error_* fns
  Note: auto-tooling is mostly copy/paste from Jeff's status test

- if symbols not found, skips.  However, if we detect we
  have a new enough MPI >= 4.1, we will print msg that these should
  exist.

Signed-off-by: Thomas Naughton <[email protected]>
@naughtont3
Copy link
Author

@jsquyres , @hppritcha: is this ok to merge to ompi-tests-public?

Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

37a64f1: Update environ-mgmt/README.md

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

beed180: Update environ-mgmt/src/test_add_del_err_codes.c

  • check_signed_off: does not contain a valid Signed-off-by line

37a64f1: Update environ-mgmt/README.md

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

c7a7142: Update environ-mgmt/src/test_add_del_err_codes.c

  • check_signed_off: does not contain a valid Signed-off-by line

6459f39: Update environ-mgmt/src/test_add_del_err_codes.c

  • check_signed_off: does not contain a valid Signed-off-by line

beed180: Update environ-mgmt/src/test_add_del_err_codes.c

  • check_signed_off: does not contain a valid Signed-off-by line

37a64f1: Update environ-mgmt/README.md

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

1 similar comment
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

c7a7142: Update environ-mgmt/src/test_add_del_err_codes.c

  • check_signed_off: does not contain a valid Signed-off-by line

6459f39: Update environ-mgmt/src/test_add_del_err_codes.c

  • check_signed_off: does not contain a valid Signed-off-by line

beed180: Update environ-mgmt/src/test_add_del_err_codes.c

  • check_signed_off: does not contain a valid Signed-off-by line

37a64f1: Update environ-mgmt/README.md

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants