Skip to content

Commit 20ac03c

Browse files
committed
config/fortran: Add note about why we reverted PR #3822
* This should be enough of a breadcrumb for when we get to fixing the `INTERFACE` check to be strong enough to kick out gfortran 4.8 Signed-off-by: Joshua Hursey <[email protected]>
1 parent c81795c commit 20ac03c

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

config/ompi_fortran_check_storage_size.m4

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ dnl University of Stuttgart. All rights reserved.
1111
dnl Copyright (c) 2004-2005 The Regents of the University of California.
1212
dnl All rights reserved.
1313
dnl Copyright (c) 2010-2014 Cisco Systems, Inc. All rights reserved.
14+
dnl Copyright (c) 2017 IBM Corporation. All rights reserved.
1415
dnl $COPYRIGHT$
1516
dnl
1617
dnl Additional copyrights may follow
@@ -27,6 +28,17 @@ dnl
2728
AC_DEFUN([OMPI_FORTRAN_CHECK_STORAGE_SIZE],[
2829
AS_VAR_PUSHDEF([fortran_storage_size_var], [ompi_cv_fortran_have_storage_size])
2930

31+
# Re PR: https://github.com/open-mpi/ompi/pull/3822
32+
# We explored correcting the following syntax to compile with gfortran 4.8
33+
# - size = storage_size(x) / 8
34+
# + size = storage_size(x(1)) / 8
35+
# That allowed gfortran 4.8 to pass this configure test, but fail to
36+
# correctly handle mpi_sizeof due to the weak test for INTERFACE in
37+
# ompi_fortran_check_interface.m4. Until we can strengthen that configure
38+
# check we reverted the commit from PR #3822 to keep the old logic here
39+
# so that gfortran 4.8 will disqualify itself correctly for mpi_sizeof()
40+
# support.
41+
#
3042
AC_CACHE_CHECK([if Fortran compiler supports STORAGE_SIZE for relevant types],
3143
fortran_storage_size_var,
3244
[AC_LANG_PUSH([Fortran])

0 commit comments

Comments
 (0)