Remove old MB() macro

In the early days of OMPI, we used MB/WMB/RMB macros instead of the
opal_atomic_* functions that most of the code uses today.  Remove
the last few places that the MB defines were used and then remove
the defines themselves.

Signed-off-by: Brian Barrett <[email protected]>

Author: bwbarrett

ompi/patterns/net/allreduce.c

@@ -5,6 +5,8 @@
  *                         All rights reserved.
  * Copyright (c) 2017      IBM Corporation. All rights reserved.
  * Copyright (c) 2019      Intel, Inc.  All rights reserved.
+ * Copyright (c) 2022      Amazon.com, Inc. or its affiliates.
+ *                         All Rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -34,7 +36,7 @@ void recv_completion(nt status, struct ompi_process_name_t* peer, struct iovec*
                      int count, ompi_rml_tag_t tag, void* cbdata)
 {
     /* set receive completion flag */
-    MB();
+    opal_atomic_mb();
     *(int *)cbdata=1;
 }
 
@@ -232,7 +234,7 @@ comm_allreduce(void *sbuf, void *rbuf, int count, opal_datatype_t *dtype,
             send_buffer^=1;
         }
 
-        MB();
+        opal_atomic_mb();
         /*
          * Signal parent that data is ready
          */
@@ -255,7 +257,7 @@ comm_allreduce(void *sbuf, void *rbuf, int count, opal_datatype_t *dtype,
 
             *recv_done=0;
             *send_done=0;
-            MB();
+            opal_atomic_mb();
 
             /* post non-blocking receive */
             recv_iov.iov_base=scratch_bufers[send_buffer];

opal/include/opal/sys/arm64/atomic.h

@@ -46,10 +46,6 @@
 #define OPAL_HAVE_ATOMIC_XOR_64              1
 #define OPAL_HAVE_ATOMIC_SUB_64              1
 
-#define MB()  __asm__ __volatile__("dmb sy" : : : "memory")
-#define RMB() __asm__ __volatile__("dmb ld" : : : "memory")
-#define WMB() __asm__ __volatile__("dmb st" : : : "memory")
-
 /**********************************************************************
  *
  * Memory Barriers
@@ -58,17 +54,17 @@
 
 static inline void opal_atomic_mb(void)
 {
-    MB();
+    __asm__ __volatile__("dmb sy" : : : "memory");
 }
 
 static inline void opal_atomic_rmb(void)
 {
-    RMB();
+    __asm__ __volatile__("dmb ld" : : : "memory");
 }
 
 static inline void opal_atomic_wmb(void)
 {
-    WMB();
+    __asm__ __volatile__("dmb st" : : : "memory");
 }
 
 static inline void opal_atomic_isync(void)

opal/include/opal/sys/gcc_builtin/atomic.h

@@ -77,7 +77,6 @@ static inline void opal_atomic_wmb(void)
     __atomic_thread_fence(__ATOMIC_RELEASE);
 }
 
-#define MB() opal_atomic_mb()
 
 /**********************************************************************
  *

opal/include/opal/sys/powerpc/atomic.h

@@ -30,11 +30,6 @@
  * On powerpc ...
  */
 
-#define MB()    __asm__ __volatile__("sync" : : : "memory")
-#define RMB()   __asm__ __volatile__ ("isync" : : : "memory")
-#define WMB()   __asm__ __volatile__("lwsync" : : : "memory")
-#define ISYNC() __asm__ __volatile__("isync" : : : "memory")
-
 /**********************************************************************
  *
  * Define constants for PowerPC 64
@@ -68,22 +63,22 @@
 
 static inline void opal_atomic_mb(void)
 {
-    MB();
+    __asm__ __volatile__("sync" : : : "memory");
 }
 
 static inline void opal_atomic_rmb(void)
 {
-    RMB();
+    __asm__ __volatile__ ("isync" : : : "memory");
 }
 
 static inline void opal_atomic_wmb(void)
 {
-    WMB();
+    __asm__ __volatile__("lwsync" : : : "memory");
 }
 
 static inline void opal_atomic_isync(void)
 {
-    ISYNC();
+    __asm__ __volatile__("isync" : : : "memory");
 }
 
 

opal/include/opal/sys/x86_64/atomic.h

@@ -16,6 +16,8 @@
  * Copyright (c) 2016-2017 Research Organization for Information Science
  *                         and Technology (RIST). All rights reserved.
  * Copyright (c) 2021      Google, LLC. All rights reserved.
+ * Copyright (c) 2022      Amazon.com, Inc. or its affiliates.
+ *                         All Rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -30,7 +32,6 @@
  */
 
 #define SMPLOCK "lock; "
-#define MB()    __asm__ __volatile__("" : : : "memory")
 
 /**********************************************************************
  *
@@ -56,12 +57,12 @@ static inline void opal_atomic_mb(void)
 
 static inline void opal_atomic_rmb(void)
 {
-    MB();
+    __asm__ __volatile__("" : : : "memory");
 }
 
 static inline void opal_atomic_wmb(void)
 {
-    MB();
+    __asm__ __volatile__("" : : : "memory");
 }
 
 static inline void opal_atomic_isync(void)