MPI-3.0+ Cleanup #4953
MPI-3.0+ Cleanup #4953
Conversation
|
@edgargabriel I will probably break out the ompio update into another PR. Seems like something that should go in regardless of the removal of MPI_Address. |
|
@hjelmn sounds good to me. |
hjelmn
force-pushed
the
mpi3_cleanup
branch
5 times, most recently
from
1a23cd2 to
268f8de
Compare
|
:bot:retest:ompi |
|
:bot:retest:mellanox |
|
Kinda funny. This PR deletes ~ 1% of all the LOC in the project. -12000 lines. |
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/5c6312268f03a40159e1c6dc621a384f |
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/ea4fe6475ee4625f03a33265c3908b12 |
|
The IBM CI (PGI Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/4f88a6e41b8ad4f886c97948ba195908 |
|
Failure was yet another place that needs to be touched when modifying fortran datatypes! Fixed. |
Signed-off-by: Nathan Hjelm <[email protected]>
This commit attempts to update the romio io component to not use functions removed in MPI-3.0 (2012). This is a first cut and will probably need to be reviewed for correctness. Signed-off-by: Nathan Hjelm <[email protected]>
This commit removes the functions that were removed from MPI-3.0 back in 2012. Signed-off-by: Nathan Hjelm <[email protected]>
The C++ bindings were removed from the MPI standard in MPI-3.0 back in 2012. This commit removes them but leaves the glue necessary to build mpicxx. Additional cleanup is probably needed. Signed-off-by: Nathan Hjelm <[email protected]>
Signed-off-by: Nathan Hjelm <[email protected]>
|
Per discussion in May 2018 and https://github.com/open-mpi/ompi/wiki/5.0.x-FeatureList, we decided that the removal of all of these features would occur in the v5.0.x timeframe (i.e., deprecate / not build by default in the v4.0.x timeframe). |
|
It looks like this PR removed the cxx bindings (done in another pr), plus a bunch of other stuff. Per the 5.0 feature list - it looks like that "other stuff" was deferred to 6.0 and beyond. Is there anything here still wanted for 5.0? |
|
This is definitely 6.0/beyond. |
|
Can one of the admins verify this patch? |
|
The IBM CI (PGI) build failed! Please review the log, linked below. Gist: https://gist.github.com/1d7a2d36b6c801a751ec3538fc8cab67 |
|
closing as too old |
7 participants
This PR cleans out all the functionality removed from MPI-3.0 in 2012. This includes a number of C and fortran functions and the entirety of the C++ bindings. The PR is a WIP intended to start the discussion about cleaning up code that is no longer supported by the standard. The intent is to bring this into master targeting the Open MPI 4.0 release.
To finish the cleanup a number of internal components needed to be modified. These components used the removed functions. The cleanup is mostly straightforward but the romio changes need to be looked at since it is likely I updated some of them incorrectly. @roblatham00, @bosilca, @jsquyres Please take a look.