libompitrace: handle MPI_DATATYPE_NULL #10035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure to check for MPI_DATATYPE_NULL before calling PMPI_Type_get_name(). As of MPI-4.0, there's still at least some disagreement as to whether MPI_DATATYPE_NULL is a valid input parameter for MPI_TYPE_GET_NAME. While that discussion is ongoing, fix up libompitrace to do what is guaranteed to work. Signed-off-by: Jeff Squyres <[email protected]>
|
I don't think this is the right approach, and if we merge this PR we will be stuck for years with an incorrect code. |
|
Can you clarify?
|
|
bot:ompi:retest |
|
This patch correctly fixes the |
bosilca
approved these changes
Feb 23, 2022
|
@bosilca and I chatted about this on the phone this morning. This PR makes libompitrace valid in all cases, regardless of whether the MPI Fourm accepts mpi-forum/mpi-issues#544 or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure to check for MPI_DATATYPE_NULL before calling
PMPI_Type_get_name(). As of MPI-4.0, there's still at least some
disagreement as to whether MPI_DATATYPE_NULL is a valid input
parameter for MPI_TYPE_GET_NAME. While that discussion is ongoing,
fix up libompitrace to do what is guaranteed to work.
Signed-off-by: Jeff Squyres [email protected]
Refs #10028, #10029, mpi-forum/mpi-issues#544, https://github.com/mpi-forum/mpi-standard/pull/652