oshmem: Add symmetric remote key handling code #11978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yosefe pls look, smkey v5.0.x commit |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 722b407: oshmem: Add symmetric remote key handling code
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
At very high scale, having each rank storing each other rank's remote keys for each segment can lead to high memory consumption. We activate symmetric remote key option to generate remote keys that will be deduplicated and then used interchangeably. Signed-off-by: Thomas Vegas <[email protected]> (cherry picked from commit 776e8ba)
tvegas1
force-pushed
the
smkey_store_v5.x
branch
from
722b407 to
9a4745f
Compare
yosefe
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick: #11893
At very high scale, having each rank storing each other rank's remote keys for
each segment can lead to high memory consumption.
We activate symmetric remote key option to generate remote keys that will be
deduplicated and then used interchangeably.
Signed-off-by: Thomas Vegas [email protected]