v5.0.x: dpm: update PMIX attribute #12015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer used the ancient/deprecate PMIX_MAPBY, and instead use PMIX_DISPLAY_MAP. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 5e695cd)
jsquyres
changed the title
|
This PR also needs the commit from #12009. EDIT: This has now been done. This PR is ready. |
Translates to its own unique PMIX_DISPLAY_MAP attribute and is no longer a qualifier to the PMIX_MAPBY attr. Note that a previous commit (5e695cd on main) converted the PMIX_MAPBY attribute to PMIX_DISPLAY_MAP; this commit completes the job by updating the surrounding logic accordingly. Signed-off-by: Ralph Castain <[email protected]> Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 75e3d33)
janjust
approved these changes
Nov 9, 2023
wenduwan
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits from main (from 2 different PRs, but addressing the same issue):
This can slip into v5.0.1; no need to hold up v5.0.0 for it.